Skip to content

fix(codegen): Never generate return structs for :exec #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2023
Merged

fix(codegen): Never generate return structs for :exec #2976

merged 3 commits into from
Nov 15, 2023

Conversation

kyleconroy
Copy link
Collaborator

Also validate :batchone commands to make sure they return values. Currently this causes a template error as seen here: https://play.sqlc.dev/p/bf5cff5c903377ae7d92efaeb063c8446b93fef7dac67188eb233f5f65095d41

Fixes #2970

DavidS-ovm
DavidS-ovm approved these changes Nov 15, 2023
View reviewed changes
Copy link

@DavidS-ovm DavidS-ovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I've verified that this works for my use-case.

@kyleconroy kyleconroy merged commit 721eba0 into main Nov 15, 2023
@kyleconroy kyleconroy deleted the kyle/fix-unused-return-struct branch November 15, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS-ovm DavidS-ovm DavidS-ovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

:exec statements can generate unused return type struct, leading to compile errors
2 participants
@kyleconroy @DavidS-ovm