fix(scripts): Remove test output regeneration script #3105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
approved these changes
Jan 4, 2024
|
What's the expected workflow for testing changes? How do I verify a codegen change doesn't affect more than I expect? |
|
The existing tests will still fail when run if you make a change that modifies their output. The regen script was mostly used to bump the sqlc version string in code comments in test output. We have another way to do that now though. To create expected output for a new test, you can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script no longer works, since test output now depends on a "context" and a significant amount of output relies on using a sqlc cloud managed database. So we should just remove the script.
Resolves #3097