Skip to content

fix(postgresql): Support renaming and dropping materialized views #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(postgresql): Support renaming and dropping materialized views #3728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: postgresql alter materialized view is not registered to statements
  • Loading branch information
Pulung Ragil committed Nov 28, 2024
commit 02a80e563cd97f40c9fb51d26c472982b143bd3e
1 change: 1 addition & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/issue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://github.com/sqlc-dev/sqlc/issues/3371
3 changes: 3 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v4/exec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"contexts": ["managed-db"]
}
32 changes: 32 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v4/go/db.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v4/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions ...al/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v4/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v4/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-- name: GetAuthorMv :one
SELECT * FROM authors_mv
WHERE id = $1 LIMIT 1;
18 changes: 18 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v4/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
CREATE TABLE authors (
id BIGSERIAL PRIMARY KEY,
name text NOT NULL,
bio text
);

CREATE MATERIALIZED VIEW authors_mv AS (
SELECT * FROM authors
);

CREATE MATERIALIZED VIEW authors_mv_new AS (
SELECT * FROM authors
);

ALTER MATERIALIZED VIEW authors_mv RENAME TO authors_mv_old;
ALTER MATERIALIZED VIEW authors_mv_new RENAME TO authors_mv;

DROP MATERIALIZED VIEW authors_mv_old;
10 changes: 10 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v4/sqlc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
version: "2"
sql:
- engine: "postgresql"
schema: "schema.sql"
queries: "query.sql"
gen:
go:
package: "querytest"
out: "go"
sql_package: "pgx/v4"
3 changes: 3 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v5/exec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"contexts": ["managed-db"]
}
32 changes: 32 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v5/go/db.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v5/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions ...al/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v5/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v5/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-- name: GetAuthorMv :one
SELECT * FROM authors_mv
WHERE id = $1 LIMIT 1;
18 changes: 18 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v5/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
CREATE TABLE authors (
id BIGSERIAL PRIMARY KEY,
name text NOT NULL,
bio text
);

CREATE MATERIALIZED VIEW authors_mv AS (
SELECT * FROM authors
);

CREATE MATERIALIZED VIEW authors_mv_new AS (
SELECT * FROM authors
);

ALTER MATERIALIZED VIEW authors_mv RENAME TO authors_mv_old;
ALTER MATERIALIZED VIEW authors_mv_new RENAME TO authors_mv;

DROP MATERIALIZED VIEW authors_mv_old;
10 changes: 10 additions & 0 deletions internal/endtoend/testdata/ddl_rename_drop_materialized_views/postgresql/pgx/v5/sqlc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
version: "2"
sql:
- engine: "postgresql"
schema: "schema.sql"
queries: "query.sql"
gen:
go:
package: "querytest"
out: "go"
sql_package: "pgx/v5"
2 changes: 1 addition & 1 deletion internal/engine/postgresql/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ func translate(node *nodes.Node) (ast.Node, error) {
MissingOk: n.MissingOk,
}, nil

case nodes.ObjectType_OBJECT_TABLE:
case nodes.ObjectType_OBJECT_TABLE, nodes.ObjectType_OBJECT_MATVIEW, nodes.ObjectType_OBJECT_VIEW:
rel := parseRelationFromRangeVar(n.Relation)
return &ast.RenameTableStmt{
Table: rel.TableName(),
Expand Down
Loading