-
Notifications
You must be signed in to change notification settings - Fork 12
fix(postgres): Handling of the decimal column in the build query #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the fix! I'll cut a new release in a few days. |
Thank you for checking despite your busy schedule. |
I apologize for the inconvenience while you are busy with the Go and TypeScript support. Will it take much longer for the release? It's tough having to manually rewrite every time I generate. Other team members are also having trouble. I'm sorry for the inconvenience, but I appreciate your consideration. 🙇 |
Hey @kyleconroy, I apologize for bugging you. Could we get a little attention to this repository? My team has been running into this big decimal issue as well (along with other compile errors that I have opened Issues and PRs for). It would be a massive help to get some of these issues merged and released. If you need help maintaining this repository, I'd be happy to help! Thank you for all the work you are doing! Really appreciate it! |
First of all, thank you for creating and maintaining such an amazing tool. While the current approach using Git patch files has reduced bug-related issues compared to before, it’s not quite what I’m hoping for. If there’s anything I can do to help, I’d be more than happy to contribute. |
Sorry that this fell off my radar! I'll attempt to cut a release this week. |
@Toru-Takagi @kyleconroy We are in trouble too. Thanks fix it!! |
Hi @kyleconroy, sorry to bother you again with how busy you are. Could we get a release cut for this PR and reviews on other opened PRs? There are other PRs that address kotlin compile errors that can occur. Thank you again for all your work! |
@kyleconroy I can contribute PRs, but without permissions to release or to review and merge changes, there’s no way to move improvements forward no matter how hard we try. Is it correct to understand that maintaining sqlc-gen-kotlin has become nearly impossible? |
fiix: #18
Problem
When creating a
decimal(19, 4)
column in PostgreSQL, it generates a data class with a property of typejava.math.BigDecimal?
.However, when generating a query for a table with this column, the code
results.getjava.math.BigDecimal()
is produced. It seems that the correct code should beresults.getBigDecimal()
.