Skip to content

fix(postgres): Handling of the decimal column in the build query #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Toru-Takagi
Copy link
Contributor

@Toru-Takagi Toru-Takagi commented Jan 10, 2024

fiix: #18

Problem

When creating a decimal(19, 4) column in PostgreSQL, it generates a data class with a property of type java.math.BigDecimal? .

However, when generating a query for a table with this column, the code results.getjava.math.BigDecimal() is produced. It seems that the correct code should be results.getBigDecimal() .

@Toru-Takagi Toru-Takagi changed the title Handling of the decimal column in the build query fix(postgres): Handling of the decimal column in the build query Jan 13, 2024
@kyleconroy
Copy link
Contributor

Thanks for the fix! I'll cut a new release in a few days.

@kyleconroy kyleconroy merged commit d3900db into sqlc-dev:main Jan 22, 2024
@Toru-Takagi
Copy link
Contributor Author

Thank you for checking despite your busy schedule.

@Toru-Takagi
Copy link
Contributor Author

@kyleconroy

I apologize for the inconvenience while you are busy with the Go and TypeScript support. Will it take much longer for the release?

It's tough having to manually rewrite every time I generate. Other team members are also having trouble.

I'm sorry for the inconvenience, but I appreciate your consideration. 🙇

@Piszmog
Copy link

Piszmog commented Apr 23, 2025

Hey @kyleconroy,

I apologize for bugging you. Could we get a little attention to this repository? My team has been running into this big decimal issue as well (along with other compile errors that I have opened Issues and PRs for). It would be a massive help to get some of these issues merged and released.

If you need help maintaining this repository, I'd be happy to help!

Thank you for all the work you are doing! Really appreciate it!

@Toru-Takagi
Copy link
Contributor Author

@kyleconroy

First of all, thank you for creating and maintaining such an amazing tool.
I’ve been using it for over a year now.

While the current approach using Git patch files has reduced bug-related issues compared to before, it’s not quite what I’m hoping for.
If the tool were actively maintained, it would be much easier to promote its use within other teams as well.

If there’s anything I can do to help, I’d be more than happy to contribute.
Thank you as always!

@kyleconroy
Copy link
Contributor

Sorry that this fell off my radar! I'll attempt to cut a release this week.

@paper2
Copy link

paper2 commented Apr 28, 2025

@Toru-Takagi @kyleconroy We are in trouble too. Thanks fix it!!

@Piszmog
Copy link

Piszmog commented May 15, 2025

Hi @kyleconroy, sorry to bother you again with how busy you are. Could we get a release cut for this PR and reviews on other opened PRs?

There are other PRs that address kotlin compile errors that can occur.

Thank you again for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants