remove literal expression error #520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #514
Removing this restriction allows literals like date/time to be used in criteria queries.
The following is valid Sql that should be allowed 💯
However, SqlDelight is using sql-psi
0.4.3
and this current0.5.0-Snapshot
is not compatible (as expected semantically) with SqlDelight. e.g https://github.com/cashapp/sqldelight/blob/master/sqldelight-compiler/src/main/kotlin/app/cash/sqldelight/core/SqlDelightEnvironment.kt#L75 and https://github.com/AlecStrong/sql-psi/blob/master/core/src/main/kotlin/com/alecstrong/sql/psi/core/SqlCoreEnvironment.kt#L68Either changes should be made on top of
0.4.3
or wait for0.5.0
to be integrated into SqlDelight ⚔️Found this
0.5.0
release to be integrated with SqlDelight 🏒 🥅 and appears to fix the breaking differencessqldelight/sqldelight#4283 (comment) - so can wait for that to be merged 🧜