-
Notifications
You must be signed in to change notification settings - Fork 545
Open
Labels
Description
SQLDelight Version
1.5.4
Application Operating System
Android
Describe the Bug
I noticed that the connection does not close when using transactions.
After a little research I found that the implementation of ConnectionManager
in JdbcDriver is overridden by JdbcSqliteDriverConnectionManager
Thus every time a new transaction is opened by JdbcSqliteDriver
the connection remains open after its completion.
So, in genereal the flow looks like this:
- Get connection or create a new one
- Create new transaction using connection
- Begin transaction
- End transaction without closing connection
Does this mean that the user has to be responsible for closing the connection every time he uses a transaction?
What is the point of overriding the functionality of JdbcDriver by JdbcSqliteDriverConnectionManager?
drakeet