MySQL: support lowercase date types and min and max on date types #4243
+90
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7abaa8b to
2955310
Compare
|
hey @hfhbd can you please take a look, I'm unable to add reviewers. |
|
I am not against lower case support, I am just surprised it works in some cases which is somehow confusing because we don't have general lowercase support. |
hfhbd
approved these changes
Jun 7, 2023
|
Shrug, we just use lowercase in our codebase, and it seems to work in all the cases. I can't kick off the build or merge btw. |
182ef95 to
8dd27d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL supports lowercase type names, and all other types are allowed in lowercase, so lets support TIMESTAMP and friends in lowercase.
Also brought back support for min/max functions on timestamps, which was working in 1.* version