Skip to content

Fix gradle tests #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 27, 2023
Merged

Fix gradle tests #4284

merged 8 commits into from
Jun 27, 2023

Conversation

hfhbd
Copy link
Collaborator

@hfhbd hfhbd commented Jun 16, 2023

The first two commits should fail, because they include #4222 but not #4282, the last merge commit should succeed because it contains 4282.

Previously, the AGP plugin was added to the build script classpath. Now the tests use the plugins block, which does not add the AGP by default.

@hfhbd hfhbd enabled auto-merge (squash) June 16, 2023 11:51
@hfhbd hfhbd force-pushed the hfhbd/fix-gradle-tests branch 2 times, most recently from 5fe2ace to 9ee2e29 Compare June 16, 2023 13:50
(cherry picked from commit 1dccb24)
@hfhbd hfhbd force-pushed the hfhbd/fix-gradle-tests branch 2 times, most recently from d874649 to 4d55f26 Compare June 16, 2023 14:18
@hfhbd hfhbd disabled auto-merge June 16, 2023 14:40
@hfhbd hfhbd force-pushed the hfhbd/fix-gradle-tests branch from 11e96e6 to 379c41f Compare June 16, 2023 15:16
@hfhbd hfhbd force-pushed the hfhbd/fix-gradle-tests branch from 379c41f to b4c052b Compare June 16, 2023 15:22
@3flex 3flex mentioned this pull request Jun 17, 2023
@hfhbd
Copy link
Collaborator Author

hfhbd commented Jun 20, 2023

  1. We have some problems with the build cache. This branch does not contain the revert, but the tests still passed.
    If I run the tests locally, I get many AndroidBasPlugin class not found errors, as expected: https://scans.gradle.com/s/6wlb2tqykcbt2/tests/:sqldelight-gradle-plugin:test/app.cash.sqldelight.integrations.GradleVersionsTest/integration%20jvm%20compiles%20successfully%20with%20different%20Gradle%20versions%5B8.0.2%5D?top-execution=1

  2. Beside the build cache errors, I finally managed to get only 4 remaining test failures: https://scans.gradle.com/s/4frqcjzkrzpwm/tests/overview?outcome=failed
    They all use a dependency database and have the same error: Cannot depend on a module with no sqldelight plugin., so I guess we need to fix this, which sounds similar to Gradle plugin: project dependency: project.evaluationDependsOn fails with Gradle 8 and included build logic #3952.

I will fix it by reopen #3774, but I prefer to use #4286 as base.
So what about merging #4286 first without actually testing it?

Alternative: Disable the 4 failing tests, clean the build cache, merge the revert commit and merge this PR, and then #4286.

@AlecKazakova
Copy link
Collaborator

Cool with the merge approach, just merged that PR

@hfhbd hfhbd merged commit d597342 into master Jun 27, 2023
@hfhbd hfhbd deleted the hfhbd/fix-gradle-tests branch June 27, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants