Skip to content

Gradle tweaks #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 26, 2023
Merged

Gradle tweaks #4286

merged 13 commits into from
Jun 26, 2023

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Jun 17, 2023

#4222 with a fix for:

java.lang.NoClassDefFoundError: com/android/build/gradle/api/AndroidBasePlugin

The plugin now checks for plugins.withId("com.android.base") instead of plugins.withType(AndroidBasePlugin::class.java) which should resolve that problem.

I can rebase once #4284 is merged if preferred, just let me know.

Copy link
Collaborator

@AlecKazakova AlecKazakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@hfhbd
Copy link
Collaborator

hfhbd commented Jun 19, 2023

I will try to fix the tests #4284 today.

@hfhbd hfhbd mentioned this pull request Jun 20, 2023
@AlecKazakova AlecKazakova merged commit fe31c16 into sqldelight:master Jun 26, 2023
@3flex 3flex deleted the gradle-tweaks-2023-06-17 branch June 27, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants