feat: add initialOffset for OffsetQueryPagingSource #4802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MohamadJaara Please run |
|
These changes will break the ABI. Are we okay with it due to the status of this module? Or do we need a binary compatibility overload? |
|
@hfhbd i added new functions with the initial value hopfully this will be fine |
|
I assume we want a default param for initialOffset anyways which we could @jvmoverloads to get binary compatibility |
|
@AlecKazakova do you mean for the internal class OffsetQueryPagingSource<RowType : Any> @JvmOverloads constructor (
private val queryProvider: (limit: Int, offset: Int) -> Query<RowType>,
private val countQuery: Query<Int>,
private val transacter: TransacterBase,
private val context: CoroutineContext,
private val initialOffset: Int = 0,
) : QueryPagingSource<Int, RowType>() {or for the functions @Suppress("FunctionName")
@JvmName("QueryPagingSourceInt")
@JvmOverloads
fun <RowType : Any> QueryPagingSource(
countQuery: Query<Int>,
transacter: TransacterBase,
context: CoroutineContext,
queryProvider: (limit: Int, offset: Int) -> Query<RowType>,
initialOffset: In = 0,
): PagingSource<Int, RowType> = OffsetQueryPagingSource(
queryProvider,
countQuery,
transacter,
context,
initialOffset,
) |
|
for ABI compatibility we would need both |
|
The constructor does not need overloads because nobody except our own code is referencing it. |
|
cool, just the methods then |
AlecKazakova
approved these changes
Nov 30, 2023
...ions/androidx-paging3/src/commonMain/kotlin/app/cash/sqldelight/paging3/QueryPagingSource.kt
Show resolved
Hide resolved
AlecKazakova
approved these changes
Nov 30, 2023
AlecKazakova
pushed a commit
that referenced
this pull request
Dec 1, 2023
* feat: add initialOffset for OffsetQueryPagingSource * apply spotless check * binary compatibility overload * typo * add @jvmoverloads for ABI compatibility * add @jvmoverloads for ABI compatibility
AlecKazakova
added a commit
that referenced
this pull request
Dec 1, 2023
* Test against 2023.2 * Update dependency mkdocs-material-extensions to v1.3.1 (#4832) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency com.squareup:kotlinpoet to v1.15.2 (#4855) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bump sql-psi to 0.5.0 (#4794) * Bump sql-psi to 0.5.0-SNAPSHOT * Use published loadFolderFromResources function * Expose HSQL test-fixtures * Expose MySql test-fixtures * Move timber from sql-psi to sqldelight * Expose Sqlite Json test-fixtures * Expose Sqlite 3.18 test-fixtures * Expose Sqlite 3.24 test-fixtures * Expose Sqlite 3.25 test-fixtures * Expose Sqlite 3.30 test-fixtures * Expose Sqlite 3.33 test-fixtures * Expose Sqlite 3.35 test-fixtures * Expose Sqlite 3.38 test-fixtures * Spotless * Adopt changed sql-psi api * Add snapshot repo to test snapshot * Fix Infer between * Add missing snapshot repo * Add missing snapshot repo * Switch to the release version * Use new loadFolderFromResources shortcut --------- Co-authored-by: hfhbd <hfhbd@users.noreply.github.com> * Add TRUNCATE to postgres dialect (#4817) Co-authored-by: Alec Kazakova <1675456+AlecKazakova@users.noreply.github.com> * feat: add initialOffset for OffsetQueryPagingSource (#4802) * feat: add initialOffset for OffsetQueryPagingSource * apply spotless check * binary compatibility overload * typo * add @jvmoverloads for ABI compatibility * add @jvmoverloads for ABI compatibility * Update agp to v8.2.0 (#4861) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update plugin intellij to v1.16.1 (#4862) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix compatibility issues --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Philip Wedemann <22521688+hfhbd@users.noreply.github.com> Co-authored-by: hfhbd <hfhbd@users.noreply.github.com> Co-authored-by: Bastien de Luca <de-luca@users.noreply.github.com> Co-authored-by: Mohamad Jaara <jaara.moh@gmail.com>
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* feat: add initialOffset for OffsetQueryPagingSource * apply spotless check * binary compatibility overload * typo * add @jvmoverloads for ABI compatibility * add @jvmoverloads for ABI compatibility
hfhbd
added a commit
that referenced
this pull request
Apr 2, 2024
* Test against 2023.2 * Update dependency mkdocs-material-extensions to v1.3.1 (#4832) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency com.squareup:kotlinpoet to v1.15.2 (#4855) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bump sql-psi to 0.5.0 (#4794) * Bump sql-psi to 0.5.0-SNAPSHOT * Use published loadFolderFromResources function * Expose HSQL test-fixtures * Expose MySql test-fixtures * Move timber from sql-psi to sqldelight * Expose Sqlite Json test-fixtures * Expose Sqlite 3.18 test-fixtures * Expose Sqlite 3.24 test-fixtures * Expose Sqlite 3.25 test-fixtures * Expose Sqlite 3.30 test-fixtures * Expose Sqlite 3.33 test-fixtures * Expose Sqlite 3.35 test-fixtures * Expose Sqlite 3.38 test-fixtures * Spotless * Adopt changed sql-psi api * Add snapshot repo to test snapshot * Fix Infer between * Add missing snapshot repo * Add missing snapshot repo * Switch to the release version * Use new loadFolderFromResources shortcut --------- Co-authored-by: hfhbd <hfhbd@users.noreply.github.com> * Add TRUNCATE to postgres dialect (#4817) Co-authored-by: Alec Kazakova <1675456+AlecKazakova@users.noreply.github.com> * feat: add initialOffset for OffsetQueryPagingSource (#4802) * feat: add initialOffset for OffsetQueryPagingSource * apply spotless check * binary compatibility overload * typo * add @jvmoverloads for ABI compatibility * add @jvmoverloads for ABI compatibility * Update agp to v8.2.0 (#4861) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update plugin intellij to v1.16.1 (#4862) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix compatibility issues --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Philip Wedemann <22521688+hfhbd@users.noreply.github.com> Co-authored-by: hfhbd <hfhbd@users.noreply.github.com> Co-authored-by: Bastien de Luca <de-luca@users.noreply.github.com> Co-authored-by: Mohamad Jaara <jaara.moh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces initialOffset parameter to
OffsetQueryPagingSource, allowing consumers to set a custom starting point. Enhances flexibility and control over data retrieval.