Fixes 5059 add brin gist #5124
Merged
Fixes 5059 add brin gist #5124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add operator classes e.g jsonb_ops Add index method e.g GIST Add storage parameters e.g fastupdate
For annotation Currently validates the storage parameters
Update Sample.s
AlecKazakova
approved these changes
Apr 8, 2024
|
@griffio what can I do to get this in a new release? Not having hash indexes is a blocker for a performance issue we have. |
@justin-robinson Last release was April, I don't think there is a schedule, it's when the maintainers have time to create a release - however I use the snapshot version as this always has merged fixes/features on see example for snapshot https://github.com/griffio/sqldelight-postgres-01/blob/master/build.gradle.kts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5059
Updated
CREATE INDEXto support operator classes e.gjsonb_path_ops, storage parameters e.ggin_pending_list_limitand index methods forBRIN,BTREE,GIN,GIST,HASHAdded integration tests for index methods and storage parameters
There are many op classes and it may not be possible to validate them, extra ones are added by extensions, and the data types they support
The optional WITH clause specifies storage parameters for the index. Each index method has its own set of allowed storage parameters. https://www.postgresql.org/docs/16/sql-createindex.html#SQL-CREATEINDEX-STORAGE-PARAMETERS
Index storage parameters are possible to validate, along with the arguments
e.g
Added
CreateIndexMixinto annotate errors with storage parametersUpdated fixtures with different index methods and invalid options
📔
ALTER INDEXis not currently implemented in any grammar as is non-standard (as sqlite doesn't supportALTER INDEX)Currently
DROP INDEXmust be used instead