Fix SqlDelightModule type resolver order #5625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns the typeResolver that is composed of either: DialectTypeResolver(AnsiTypeResolver) - default When loading a SqlDelightModule use ModuleTypeResolver(DialectTypeResolver(AnsiTypeResolver)) This ensures that the Module TypeResolver methods are called first and can delegate to the immediate dialect parent for the base types
|
Dialect modules maybe an alternative way in supporting third-party PostgreSql extensions like e.g Locally, I created a hacky proof of concept for the same sqldelight {
databases {
create("Sample") {
dialect("app.cash.sqldelight:postgresql-dialect:2.0.2")
module("app.cash.sqldelight:postgresql-postgis-module:2.0.2")
}
}
} |
vanniktech
approved these changes
Jan 23, 2025
hfhbd
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue when looking into SqlDelightModules for potential use with PostgreSql Extensions - noticed that the typeResolver order is incorrect when loading a module
DialectTypeResolver -> ModuleTypeResolver -> AnsiTypeResolver.Currently it worked for Sqlite JsonModule as only added functions and not any types
Fix returns the typeResolver and parent resolver(s) composed of either:
DialectTypeResolver -> AnsiTypeResolver- no SqlDelightModuleModuleTypeResolver -> DialectTypeResolver -> AnsiTypeResolver- with SqlDelightModuleThis ensures that the Module TypeResolver methods are called first and can delegate to the dialect parent resolver for any inherited types and then the Ansi Resolver