Browse Data: Use Tab to close autocomplete popup and move to next item

lucydodo · lucydodo · commit 3aff8c925e07 · 2024-10-07T10:34:45.000+09:00
Fix #3743
diff --git a/src/ExtendedTableWidget.cpp b/src/ExtendedTableWidget.cpp
@@ -185,6 +185,9 @@ QWidget* ExtendedTableWidgetEditorDelegate::createEditor(QWidget* parent, const
             completer->setCompletionMode(QCompleter::PopupCompletion);
             completer->setCaseSensitivity(Qt::CaseInsensitive);
             editor->setCompleter(completer);
+
+            CompleterTabKeyPressedEventFilter* completerTabHandleFilter = new CompleterTabKeyPressedEventFilter(completer);
+            completer->popup()->installEventFilter(completerTabHandleFilter);
         }
         // Set the maximum length to the highest possible value instead of the default 32768.
         editor->setMaxLength(std::numeric_limits<int>::max());
diff --git a/src/ExtendedTableWidget.h b/src/ExtendedTableWidget.h
@@ -1,6 +1,10 @@
 #ifndef EXTENDEDTABLEWIDGET_H
 #define EXTENDEDTABLEWIDGET_H
 
+#include <QApplication>
+#include <QCompleter>
+#include <QEvent>
+#include <QKeyEvent>
 #include <QTableView>
 #include <QStyledItemDelegate>
 #include <QSortFilterProxyModel>
@@ -30,6 +34,35 @@ class UniqueFilterModel : public QSortFilterProxyModel
     std::unordered_set<std::string> m_uniqueValues;
 };
 
+// Handler for pressing the tab key when the autocomplete popup is open, closing the popup and moving the cursor to the next item.
+class CompleterTabKeyPressedEventFilter : public QObject
+{
+    Q_OBJECT
+
+public:
+    CompleterTabKeyPressedEventFilter(QObject* parent = nullptr) : QObject(parent) {}
+
+protected:
+    bool eventFilter(QObject* obj, QEvent* event) override {
+        if (event->type() == QEvent::KeyPress) {
+            QKeyEvent* keyEvent = static_cast<QKeyEvent*>(event);
+            if (keyEvent->key() == Qt::Key_Tab) {
+                QCompleter* completer = qobject_cast<QCompleter*>(this->parent());
+                if (completer) {
+                    completer->popup()->hide();
+                    QWidget* editor = completer->widget();
+                    if (editor) {
+                        QKeyEvent tabEvent(QEvent::KeyPress, Qt::Key_Tab, Qt::NoModifier);
+                        QApplication::sendEvent(editor, &tabEvent);
+                    }
+                }
+                return true;
+            }
+        }
+        return QObject::eventFilter(obj, event);
+    }
+};
+
 // We use this class to provide editor widgets for the ExtendedTableWidget. It's used for every cell in the table view.
 class ExtendedTableWidgetEditorDelegate : public QStyledItemDelegate
 {
