Skip to content

Consistent naming of DB Browser for SQLite #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2020
Merged

Consistent naming of DB Browser for SQLite #2224

merged 2 commits into from
Apr 30, 2020

Conversation

horst-p-w-neubauer
Copy link
Member

done:

  • change all DB4S to DB Browser for SQLite
  • change "Click the button to create a DB4S certificate" to "Click the button to 'Generate client certificate'"

@horst-p-w-neubauer
consistent naming of DB Browser for SQLite
48efd00 
done:
* change all DB4S to DB Browser for SQLite
* change "Click the button to create a DB4S certificate" to "Click the button to 'Generate client certificate'"
@horst-p-w-neubauer
Copy link
Member Author

Before merging the .ts files should be updated - I'm just waiting for approval of the text changes.

@justinclift
Copy link
Member

Yep, the text changes here are good. 😄

@horst-p-w-neubauer
Copy link
Member Author

When I update the .ts files I get some more changes than those I've initiated, I'd push them too. The alternative would be to extract them manually - that might be dangerous.

@horst-p-w-neubauer
Copy link
Member Author

@justinclift, What about the libs\qscintilla\Qt4Qt5*.ts files? Should I commit the changes or ignore?

@scottfurry
Copy link
Contributor

scottfurry commented Apr 30, 2020 via email •
edited by justinclift
Loading

@horst-p-w-neubauer
translation files updated
80875e0 
translation files updated expect libs
@horst-p-w-neubauer
Copy link
Member Author

translating itself is probably a different commit / pr cycle

@justinclift
Copy link
Member

Yep, the translating itself is a different PR, as that'll need to be done by a bunch of different people.

Sounds like this PR is ready to merge now though. Yes? 😄

@horst-p-w-neubauer
Copy link
Member Author

Yes!

@justinclift
Copy link
Member

Awesome! Thanks heaps for taking care of this stuff @horst-p-w-neubauer. 😄

@justinclift justinclift merged commit 253fcae into sqlitebrowser:master Apr 30, 2020
justinclift pushed a commit that referenced this pull request Apr 30, 2020
@horst-p-w-neubauer @justinclift
Consistent naming of DB Browser for SQLite (#2224)
9ed42a1
@horst-p-w-neubauer horst-p-w-neubauer deleted the Naming-DB-Browser-for-SQLite-base branch April 30, 2020 22:31
@justinclift
Copy link
Member

I've just applied this PR to the v3.12.x branch too, for good measure. 😄

@justinclift justinclift added this to the 3.12.0 - Next release milestone Apr 30, 2020
@horst-p-w-neubauer horst-p-w-neubauer mentioned this pull request May 1, 2020
Merged
@justinclift justinclift changed the title consistent naming of DB Browser for SQLite Consistent naming of DB Browser for SQLite Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@horst-p-w-neubauer horst-p-w-neubauer

Labels
None yet
Projects
None yet
Milestone
3.12.0 - Next release
Development

Successfully merging this pull request may close these issues.
3 participants
@horst-p-w-neubauer @justinclift @scottfurry