fix: Add Gemini tool schema sanitization to MCP tools as well #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae235d5 to
7091508
Compare
|
@thdxr turns out my previous fix didn't go far enough, would appreciate 👀 here too. |
Extends existing Gemini compatibility by applying provider-specific transformations at the middleware level, ensuring consistent tool schema handling for both built-in and MCP tools. Co-Authored-By: opencode <noreply@opencode.ai>
Fixed syntax error in session/index.ts where an if statement inside a .then() block was missing its closing brace, causing TypeScript compilation to fail. 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>
Implemented the missing transformToolSchema function that converts Zod schemas to JSON schemas and applies provider-specific transformations. This method is used by the session chat functionality to transform tool schemas for different providers, particularly applying Gemini-specific sanitization for Google provider. The function handles both Zod schemas and plain JSON schema objects, and includes error handling with logging for failed transformations. 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>
7091508 to
7e472f3
Compare
…ema in ProviderTransform 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <noreply@opencode.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to built-in tools in
TOOL_MAPPING, add Gemini tool sanitization toMCP.tools()as well. This should have broader effects -- like fixing #1052 .