Skip to content

Conversation

alcpereira
Copy link

  • Leverage existing open library to open automatically the browser to improve the Github auth UX (I was expecting the browser to open automatically)
  • Small refactor:
    • the returned object from authorize is now closer to the API response
    • destructure the object instead of deviceInfo

@alcpereira alcpereira force-pushed the feat/open-github-browser branch from c88960a to 6feeccd Compare June 27, 2025 10:57
device: deviceData.device_code,
user: deviceData.user_code,
verification: deviceData.verification_uri,
deviceCode: deviceData.device_code,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thdxr I've noticed you externalised this auth (4d3d632).

Two quick questions:

  • Do you agree with my suggested changes? If so, I will replicate them into the new repo.
  • We should remove completely this file github-copilot.ts, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants