-
Notifications
You must be signed in to change notification settings - Fork 456
Add an OAuth provider for Twitch #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Nachwahl is attempting to deploy a commit to the Stack Team on Vercel. A member of the Team first needs to authorize it. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added Twitch OAuth provider integration across the stack with UI components and backend support.
- Potential security concern in
apps/backend/src/oauth/providers/twitch.tsx
needs attention for proper error handling and data validation - Uses Plain Object for response handling in Twitch provider instead of Map, consider using Map to prevent prototype pollution (see
postProcessUserInfo
method) - New Twitch provider follows consistent pattern with existing OAuth providers but needs additional validation
- Added brand-consistent purple (#9146FF) Twitch icon implementation in
packages/stack-ui/src/components/brand-icons.tsx
- Standardized OAuth provider type with 'TWITCH' enum in Prisma schema for database consistency
7 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
😱 Found 3 issues. Time to roll up your sleeves! 😱 🗒️ View all ignored comments in this repo
Need help? Join our Discord for support! |
oauth-button.mdx
This change is required to reflect the addition of Twitch as a new OAuth provider in the OAuthButton component. Please ensure these changes are made in the documentation to keep it consistent with the recent updates. |
Can you give me permission to edit this PR? |
Sure! Do you need permission to our respository? |
|
Done 👍 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important
Add Twitch as a new OAuth provider, updating backend logic and UI components to support Twitch authentication.
TwitchProvider
class inproviders/twitch.tsx
to handle OAuth with Twitch, including user info post-processing._providers
inindex.tsx
to includeTwitchProvider
.TWITCH
toStandardOAuthProviderType
enum inschema.prisma
.brand-icons.tsx
andBRAND_COLORS
.ProviderIcon
,ProviderSettingDialog
, andOAuthButton
to support Twitch inproviders.tsx
andoauth-button.tsx
.twitch
tostandardProviders
inoauth.tsx
.This description was created by
for 08c0de5. You can customize this summary. It will automatically update as commits are pushed.