apps/backend/src/lib/config.tsx (3)

212-220: Harden size guard: use named constants; keep message MB calc single-sourced

Functionally correct, but the magic numbers repeat and the division factor appears in two places. Use constants to reduce drift and improve readability.

-  const newConfigString = JSON.stringify(newConfig);
-  if (newConfigString.length > 1_000_000) {
-    captureError("override-project-config-too-large", new StackAssertionError(`Project config override for ${options.projectId} is ${(newConfigString.length/1_000_000).toFixed(1)}MB long!`));
-  }
-  if (newConfigString.length > 5_000_000) {
-    throw new StackAssertionError(`Project config override for ${options.projectId} is too large.`);
-  }
+  const newConfigString = JSON.stringify(newConfig);
+  if (newConfigString.length > CONFIG_OVERRIDE_WARN_MB * BYTES_PER_MB) {
+    captureError(
+      "override-project-config-too-large",
+      new StackAssertionError(
+        `Project config override for ${options.projectId} is ${(newConfigString.length / BYTES_PER_MB).toFixed(1)}MB long!`,
+      ),
+    );
+  }
+  if (newConfigString.length > CONFIG_OVERRIDE_HARD_MB * BYTES_PER_MB) {
+    throw new StackAssertionError(`Project config override for ${options.projectId} is too large.`);
+  }

---

256-264: Duplicate size-check logic between project/env paths — factor into a helper

The environment path repeats the same guard. Extract a small helper to keep the checks consistent and reduce chances of future drift.

-  // large configs make our DB slow; let's prevent them early
-  const newConfigString = JSON.stringify(newConfig);
-  if (newConfigString.length > 1_000_000) {
-    captureError("override-environment-config-too-large", new StackAssertionError(`Environment config override for ${options.projectId}/${options.branchId} is ${(newConfigString.length/1_000_000).toFixed(1)}MB long!`));
-  }
-  if (newConfigString.length > 5_000_000) {
-    throw new StackAssertionError(`Environment config override for ${options.projectId}/${options.branchId} is too large.`);
-  }
+  enforceConfigSizeLimits(
+    "environment",
+    `${options.projectId}/${options.branchId}`,
+    newConfig,
+  );

Add this helper once in the module (outside the selected range):

function enforceConfigSizeLimits(
  scope: "project" | "environment",
  id: string,
  cfg: unknown,
) {
  const s = JSON.stringify(cfg);
  const warnKey =
    scope === "project"
      ? "override-project-config-too-large"
      : "override-environment-config-too-large";

  if (s.length > CONFIG_OVERRIDE_WARN_MB * BYTES_PER_MB) {
    captureError(warnKey, new StackAssertionError(`${scope} config override for ${id} is ${(s.length / BYTES_PER_MB).toFixed(1)}MB long!`));
  }
  if (s.length > CONFIG_OVERRIDE_HARD_MB * BYTES_PER_MB) {
    throw new StackAssertionError(`${scope} config override for ${id} is too large.`);
  }
}

Happy to wire the project path to this helper too for symmetry.

---

1-8: Missing import for captureError + propose central constants for size math

captureError(...) is used later but not imported. Also, the MB math literals appear multiple times; pull them into named constants for clarity and consistency.

Apply this diff to import the missing symbol:

-import { StackAssertionError } from "@stackframe/stack-shared/dist/utils/errors";
+import { StackAssertionError, captureError } from "@stackframe/stack-shared/dist/utils/errors";

Optionally add shared constants near the imports:

// bytes/limits for config override size checks
const BYTES_PER_MB = 1_000_000;
const CONFIG_OVERRIDE_WARN_MB = 1; // warn at 1MB
const CONFIG_OVERRIDE_HARD_MB = 5; // hard-fail at 5MB

apps/backend/src/app/api/latest/integrations/neon/domains/crud.tsx (1)

59-61: Off-by-one: cap at 1000 should block when count is already 1000 (use >=)

As written, a project with exactly 1000 domains can still add a 1001st. Fix the predicate and avoid magic numbers with a named constant.

-    if (Object.keys(oldDomains).length > 1000) {
-      throw new StatusError(400, "This project has more than 1000 trusted domains. This is not supported. Please delete some domains to add a new one, or use wildcard domains instead.");
-    }
+    // Enforce hard cap of 1000 domains
+    if (Object.keys(oldDomains).length >= MAX_TRUSTED_DOMAINS) {
+      throw new StatusError(
+        400,
+        `This project already has ${MAX_TRUSTED_DOMAINS} trusted domains. Delete some or use wildcard domains instead.`
+      );
+    }

Add near the top of the file:

const MAX_TRUSTED_DOMAINS = 1000;

Follow-up options:

• Extract this check into a small shared util to de-duplicate custom/neon handlers.
• Optionally reject duplicate domains on create to avoid unnecessary consumption of the cap.

Would you like me to propose a tiny shared helper and wire both handlers?

apps/backend/src/app/api/latest/integrations/custom/domains/crud.tsx (1)

60-62: Off-by-one: block creation when count is already 1000

Use >= and a shared constant to match the intended cap. This logic is duplicated across integrations; consider extracting.

-    if (Object.keys(oldDomains).length > 1000) {
-      throw new StatusError(400, "This project has more than 1000 trusted domains. This is not supported. Please delete some domains to add a new one, or use wildcard domains instead.");
-    }
+    if (Object.keys(oldDomains).length >= MAX_TRUSTED_DOMAINS) {
+      throw new StatusError(
+        400,
+        `This project already has ${MAX_TRUSTED_DOMAINS} trusted domains. Delete some or use wildcard domains instead.`
+      );
+    }

Add near the top:

const MAX_TRUSTED_DOMAINS = 1000;

If you want, I can draft a tiny helper (e.g., enforceTrustedDomainLimit(oldDomains)) and use it in both files.

packages/stack-shared/src/config/schema.ts (1)

216-218: LGTM: 300-char caps on baseUrl/handlerPath

The max(300) aligns with the CRUD input schema. Keeps oversized entries out at the schema layer.

Optional: consider centralizing 300 as a shared constant (e.g., in schema-fields) to keep CRUD and schema in lockstep and avoid drift.

apps/backend/src/app/api/latest/integrations/neon/domains/crud.tsx (1)

11-13: Domain schema upgrade looks good

Switch to wildcardUrlSchema with 300-char cap and explicit http(s) check is consistent with the PR objective.

If wildcardUrlSchema already enforces http(s), the additional .matches may be redundant. Not a blocker.

apps/backend/src/app/api/latest/integrations/custom/domains/crud.tsx (1)

11-13: Domain schema upgrade looks good

Wildcards + 300-char limit matches the Neon handler and shared schema.

Same note as Neon: the explicit http(s) regex may be redundant if wildcardUrlSchema already guarantees it.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.