Skip to content

fix dynamic insert-css usage #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2020
Merged

fix dynamic insert-css usage #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9518f6
fix dynamic insert-css usage
ahdinosaur Dec 15, 2016
90e8a58
Merge branch 'master' into dynamic
goto-bus-stop Aug 6, 2020
5b65566
rm console.log
goto-bus-stop Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,26 @@ test('css-extract', function (t) {
t.ok(String(data).indexOf(String(source)) !== -1, 'source is still in built bundle')
}
})

t.test('should not extract dynamic insert-css statements, again', function (t) {
t.plan(4)
const sourcePath = path.join(__dirname, 'source-dynamic-2.js')

browserify(sourcePath)
.plugin(cssExtract, { out: readCss })
.bundle(readJs)

function readCss () {
return bl(function (err, data) {
t.ifError(err, 'no error')
t.equal(String(data), '', 'no css extracted')
})
}

function readJs (err, data) {
t.ifError(err, 'no error')
const source = fs.readFileSync(sourcePath, 'utf8')
t.ok(String(data).indexOf(String(source)) !== -1, 'source is still in built bundle')
}
})
})
7 changes: 7 additions & 0 deletions test/source-dynamic-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
var insertCss = require('insert-css')

insert('.foo {}')

function insert (foo) {
insertCss(foo)
}