fix: Explicitly name click objects that end with magic suffixes (ENG-5110) #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howbazaar
approved these changes
May 13, 2025
…5110) Click 8.2.0 includes this change: "When generating a command’s name from a decorated function’s name, the suffixes _command, _cmd, _group, and _grp are removed.". That renamed our `user ensure-group` command to `user ensure`, and caused our `account-group` group to now clobber the `account` group. This broke platform functional tests.
65d5d5d to
8a49cde
Compare
Merged
wgrant
added a commit
that referenced
this pull request
May 13, 2025
### what Release 0.1.5 Also try to unbitrot the release workflow. ### why #67 fixes an account, account-group and user command regression with click 8.2.0, so we should get it out there. ### testing platform functional tests no longer fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-5110
what
Explicitly name click objects that end with magic suffixes
why
Click 8.2.0 includes this change: "When generating a command’s name from a decorated function’s name, the suffixes _command, _cmd, _group, and _grp are removed.". That renamed our
user ensure-groupcommand touser ensure, and caused ouraccount-groupgroup to now clobber theaccountgroup.poetry doesn't pull in 8.2.0 yet, as we support older Pythons than the new Click does. But this broke platform functional tests, which install directly through pip.
testing
Manually, sadly. But platform ftests will verify it.