Skip to content

Conversation

albertodonato
Copy link
Contributor

what

Add the missing ses_region attribute to email profile datasource.
Also simplify the code to get the SMTP configuration.

why

it's provided in the API, but wasn't exposed in the model

testing

tested in sandbox

docs

updated

@albertodonato albertodonato requested a review from a team as a code owner August 26, 2025 07:24
Copy link
Contributor

@fwereade fwereade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggled a little with whether we want a Conflicting validator for ses/smtp, but ultimately I don't think it really helps to paper over the model flaws in terraform here. LGTM, thank you.

### what

Add the missing `ses_region` attribute to email profile datasource.
Also simplify the code to get the SMTP configuration.

### why

it's provided in the API, but wasn't exposed in the model

### testing

tested in sandbox

### docs

updated
@albertodonato albertodonato merged commit 336590c into main Aug 26, 2025
6 checks passed
@albertodonato albertodonato deleted the ack/email-ds-fixes branch August 26, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants