-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add copyright headers [ENG-5168] #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The first commit has the actual changes, the rest is autogenerated by running |
ef0a9e3
to
4d65799
Compare
@albertodonato elsewhere this looks like this:
I think at the very least I'd like to see a) the year and b) 'Stacklet, Inc.' as are formal name, if it's possible with the tool you're using? |
bcc08c3
to
da6f185
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we clearly will need a license, and I'm suspicious about the lack of year in the generated headers, but I'm happy with the infrastructure for generating them, so LGTM as a capability, I just wouldn't want to release like this ;).
@jtroup @fwereade thanks for the review. It seems copywrite doesn't support having the year directly (I'm actually not sure what the value in the config is used for), but looking at this it seems one option is to add it in the copyright holder string. The hashicorp sample provider has this:
Alternatively there's
(technically It still doesn't seem to support updating headers once they're there, but maybe it's a better solution given copywright limitations |
c58a9b5
to
f03a843
Compare
2af1ed9
to
8c26792
Compare
[ENG-5168](https://stacklet.atlassian.net/browse/ENG-5168) ### what - add copywrite setup to generate headers - add license headers to all files - check in CI that all fiels have a header ### why ensure copyright is set on all files ### testing added CI check ### docs n/a
8c26792
to
5b79c92
Compare
ENG-5168
what
why
ensure copyright is set on all files
testing
added CI check
docs
n/a