Skip to content

Conversation

albertodonato
Copy link
Contributor

@albertodonato albertodonato commented May 28, 2025

ENG-5098

what

  • add helper to generate the ImportStateIdFunc for import state tests
  • update all tests to use it and not use fixed value ImportStateIds

why

make it possible to run all tests against a sandbox, where UUIDs would differ
from run to run

testing

this is updating tests

docs

n/a

[ENG-5098](https://stacklet.atlassian.net/browse/ENG-5098)

### what

- add helper to generate the `ImportStateIdFunc` for import state tests
- update all tests to use it and not use fixed value `ImportStateId`s

### why

make it possible to run all tests against a sandbox, where UUIDs would differ
from run to run

### testing

this is updating tests

### docs

n/a
@albertodonato albertodonato requested a review from a team as a code owner May 28, 2025 06:47
Copy link
Contributor

@fwereade fwereade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM, thank you.

@albertodonato albertodonato merged commit 781f888 into main May 28, 2025
6 checks passed
@albertodonato albertodonato deleted the ack/test-fixes branch May 28, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants