-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add support for dynamic policy collections [ENG-5169] #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ENG-5169](https://stacklet.atlassian.net/browse/ENG-5169) ### what add support for managing dynamic policy collections ### why support the API feature in terraform as well ### testing acceptance tests and testing in sandbox ### docs updated here
b6fb718
to
b6015e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment and a question, neither blocking
@@ -13,28 +13,27 @@ Manages a policy collection. | |||
## Example Usage | |||
|
|||
```terraform | |||
# Create an AWS policy collection | |||
# Create a policy collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertodonato While I'm fine dropping it down to just one example, I wonder if it's worth being explicit that policies support any cloud Stacklet supports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It felt to me like given that the only difference in the example is the cloud provider it's not really useful to have multiple definitions.
auto_update = true | ||
dynamic_config = { | ||
repository_uuid = data.stacklet_repository.policies.uuid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertodonato Is the UUID auto-generated/derived by the provider? In repository.md
it's listed as an optional parameter and obviously not defined in lines 24-26 above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the UUID is the identifier of the API entity which is generated by platform when it's created (this is true for anything in platform, repositories, account groups, policy collections,...).
The reason it's marked as optional in the repository data source is that you can define a data source by passing either the ID or the URL, so those parameters need to be marked as such or terraform will complain when one of them is not provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
ENG-5169
what
add support for managing dynamic policy collections
why
support the API feature in terraform as well
testing
acceptance tests and testing in sandbox
docs
updated here