Skip to content

Conversation

albertodonato
Copy link
Contributor

@albertodonato albertodonato commented Jun 11, 2025

ENG-5152

what

  • replace execution_config nested object with individual settings
  • add settings for default resource limits

why

parity with the API

testing

acceptance tests and sandbox testing

docs

updated here

@albertodonato albertodonato requested a review from a team as a code owner June 11, 2025 14:54
@albertodonato albertodonato force-pushed the ack/binding-default-resource-limits branch 2 times, most recently from 39fb221 to b983ff6 Compare June 11, 2025 15:38
Copy link
Contributor

@fwereade fwereade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer, thank you; LGTM with minors/suggestions

[ENG-5152](https://stacklet.atlassian.net/browse/ENG-5152)

### what

add "default" limits for binding execution config

### why

parity with the API

### testing

acceptance tests and sandbox testing

### docs

updated here
@albertodonato albertodonato force-pushed the ack/binding-default-resource-limits branch 2 times, most recently from 39dabe1 to 14af9ad Compare June 11, 2025 21:26
@albertodonato albertodonato force-pushed the ack/binding-default-resource-limits branch from 14af9ad to 2589324 Compare June 12, 2025 07:00
@albertodonato albertodonato merged commit f60a465 into main Jun 12, 2025
6 checks passed
@albertodonato albertodonato deleted the ack/binding-default-resource-limits branch June 12, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants