Skip to content

feat: rework policy_resource_limits as a block #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

feat: rework policy_resource_limits as a block #78

merged 1 commit into from
Jun 16, 2025

Conversation

albertodonato
Copy link
Contributor

@albertodonato albertodonato commented Jun 16, 2025 •
edited
Loading

what

  • replace the policy_resource_limits map with policy_resouce_limit blocks
  • validate that the policy names are unique across blocks

why

better align with typical terraform style

testing

updated tests, tested in sandbox

docs

updated here

@albertodonato albertodonato marked this pull request as ready for review June 16, 2025 15:09
@albertodonato albertodonato requested a review from a team as a code owner June 16, 2025 15:09
@albertodonato albertodonato marked this pull request as draft June 16, 2025 15:59
@albertodonato albertodonato force-pushed the ack/policy-resource-limits-block branch 2 times, most recently from ea1cf0b to 17fb6a3 Compare June 16, 2025 16:22
@albertodonato albertodonato marked this pull request as ready for review June 16, 2025 16:23
@albertodonato
feat: rework policy_resource_limits as a block
73d8969 
### what

<here>

### why

<here>

### testing

<here>

### docs

<here>
@albertodonato albertodonato force-pushed the ack/policy-resource-limits-block branch from 17fb6a3 to 73d8969 Compare June 16, 2025 17:10
@albertodonato albertodonato merged commit 7b12d40 into main Jun 16, 2025
6 checks passed
@albertodonato albertodonato deleted the ack/policy-resource-limits-block branch June 16, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sontek sontek sontek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertodonato @sontek