feat: add datasource for report groups [ENG-5559] #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ENG-5559](https://stacklet.atlassian.net/browse/ENG-5559) ### what Add datasource for notification report groups. ### why allow accessing information about existing report groups. ### testing Local testing in sandbox. It's currently quite hard to add acceptance tests, since the resource is not yet available, but will add direct tests once it is. ### docs updated here
jtroup
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
Not going to lie, this repetitive terraform provider code makes my eyes glaze over after a while. But regardless, LGTM, thanks @albertodonato !
|
thanks @jtroup , appreciate the effort going through this. And yeah, unfortunately declarations are quite verbose and it's not really easy to split up in smaller changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-5559
what
Add datasource for notification report groups.
why
allow accessing information about existing report groups.
testing
Local testing in sandbox.
It's currently quite hard to add acceptance tests, since the resource is not
yet available, but will add direct tests once it is.
docs
updated here