feat: add resource for report groups [ENG-5559] #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ENG-5559](https://stacklet.atlassian.net/browse/ENG-5559) ### what Add reource for notification report groups. Note that notification settings for the different transports are not yet handled. They're present in the resource schema but not passed to the API. This will be added in a followup branch since this one is already quite large. ### why allow managing notifications via terraform ### testing testing in sandbox, added acceptance tests ### docs updated here
6478988 to
cc37bec
Compare
fwereade
approved these changes
Aug 20, 2025
There was a problem hiding this comment.
I seem to recall that while a Recipient has multiple fields, it requires exactly one of them to be set? and I didn't spot code enforcing that… I guess that's handled on the backend, but it might be worth a mention in the schema docs as well?
Regardless, LGTM, many thanks.
|
thanks @fwereade , indeed only one of those fields can be true or not null. I'll add validation for that in the provider separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-5559
what
Add reource for notification report groups.
Note that notification settings for the different transports are not yet
handled. They're present in the resource schema but not passed to the API.
This will be added in a followup branch since this one is already quite large.
why
allow managing notifications via terraform
testing
testing in sandbox, added acceptance tests
docs
updated here