Skip to content

Link to Laravel Framework 4.2 branch #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2014
Merged

Link to Laravel Framework 4.2 branch #22

merged 1 commit into from
Dec 13, 2014

Conversation

hannesvdvreken
Copy link
Contributor

Because master is the 5.0 version in development and the CookieMiddleware will no longer be StackPHP compatible.

Because master is the 5.0 version in development and the CookieMiddleware will no longer be StackPHP compatible.
simensen added a commit that referenced this pull request Dec 13, 2014
Link to Laravel Framework 4.2 branch
@simensen simensen merged commit 016fb68 into stackphp:master Dec 13, 2014
@igorw
Copy link
Contributor

igorw commented Dec 14, 2014

This is quite unfortunate, I'd be curious to hear the motivation behind this decision. /cc @taylorotwell

@simensen
Copy link
Member

@igorw I've talked w/ @taylorotwell some. Would be good to see some reasoning posted here for posterity but I don't want to put words in his mouth. :)

@taylorotwell
Copy link

Primary reason is by not imposing any requirements on the
middleware's constructors we can more cleanly resolve them out of the IoC
container with auto dependency resolution.

On Saturday, December 13, 2014, Beau Simensen notifications@github.com
wrote:

@igorw https://github.com/igorw I've talked w/ @taylorotwell
https://github.com/taylorotwell some. Would be good to see some
reasoning posted here for posterity but I don't want to put words in his
mouth. :)


Reply to this email directly or view it on GitHub
#22 (comment).

@igorw
Copy link
Contributor

igorw commented Dec 14, 2014

@taylorotwell can you give an example of how this would be an issue? With a tiny bit of wiring it should be possible to get middlewares constructed by a DIC.

PS: I respect your decision to no longer use it. I can accept if it was done to remove conceptual overhead, because I do get that stack adds concepts. And the APIs are not necessarily in line with what laravel has to offer, etc. There are many social reasons not to use stack.

I would just appreciate to know technical reasons if they do exist, so we can come up with solutions for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants