Fix findFunctionName regex sometimes matching if constructs #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the
findFunctionName
function would falsely identify a snippet somewhere around an if/while/catch construct (basically anything that had a block with it)Description
The regex that matched with the snippet basically attempted to match anything on the form
<function name><whitespace>(<parameter list>)<whitespace>{
, so things like the following would match:foo(); } else if (b) {
(); } else if (b
, in this case, would be the parameter list)functionCall()\nif (condition) {
(in this case,functionCall()\nif
would be the function name)To work around that, I changed the regex to not matching opening parenthesis, and the regex to not match any closing parenthesis.
Motivation and Context
Fixes #54
How Has This Been Tested?
I've added an unit test, and I've tested this change with some private code that also happened to trigger this bug
Types of changes
Checklist:
npm run lint
passes without errorsnpm run test
passes without errors