Skip to content

feat: add math/base/special/gammasgnf #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

feat: add math/base/special/gammasgnf #3365

wants to merge 16 commits into from

Conversation

vivekmaurya001
Copy link
Contributor

@vivekmaurya001 vivekmaurya001 commented Dec 7, 2024 •
edited
Loading

Progresses #649

Description

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 7, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 7, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/gammasgnf $\color{green}175/175$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}175/175$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 7, 2024
@kgryte kgryte self-requested a review January 2, 2025 22:25
vivekmaurya001 and others added 2 commits January 18, 2025 21:12
@vivekmaurya001
Merge branch 'stdlib-js:develop' into gammasgnf
16dc7a8
@vivekmaurya001
add math/base/special/gammasgnf
cb42022 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@vivekmaurya001
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@vivekmaurya001
add math/base/special/gammasgnf
fa86fcd
@vivekmaurya001
Merge branch 'gammasgnf' of https://github.com/vivekmaurya001/stdlib …
87a4039 
…into gammasgnf

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001 vivekmaurya001 marked this pull request as draft January 18, 2025 16:19
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 18, 2025
@vivekmaurya001
Copy link
Contributor Author

Hi @gunjjoshi , could u please help me from where error was occuring , i have double checked the addon.c file but not found anything

@gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/gammasgnf/src/addon.c
efefd9b 
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review January 20, 2025 19:35
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 20, 2025
@vivekmaurya001
feat: add math/base/special/gammasgnf
ce4380d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: passed
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@vivekmaurya001
feat: add math/base/special/gammasgnf
fb11d85
@vivekmaurya001
Copy link
Contributor Author

@gunjjoshi , I have maded changes according to my previous PR's reviews

@vivekmaurya001 vivekmaurya001 mentioned this pull request Mar 26, 2025
Open
7 tasks
@kgryte kgryte requested a review from anandkaranubc April 30, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunjjoshi gunjjoshi gunjjoshi left review comments

@kgryte kgryte Awaiting requested review from kgryte

@anandkaranubc anandkaranubc Awaiting requested review from anandkaranubc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivekmaurya001 @stdlib-bot @Planeshifter @gunjjoshi