Apply suggestions from code review

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
stdlib-js · Planeshifter · Apr 29, 2025 · Dec 7, 2024 · Dec 7, 2024 · Dec 7, 2024
commit 41a7874b74ee3e7f52136a9ddba93812cc75e42f
diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/README.md b/lib/node_modules/@stdlib/math/base/special/logitf/README.md
@@ -20,7 +20,7 @@ limitations under the License.
 
 # logitf
 
-> Compute the [logit][logit] function for single precision-floating point number.
+> Compute the [logit][logit] function for a single-precision floating-point number.
 
 <section class="intro">
 
@@ -55,7 +55,7 @@ var logitf = require( '@stdlib/math/base/special/logitf' );
 
 #### logitf( p )
 
-Computes the [logit][logit] function for single precision-floating point number.
+Computes the [logit][logit] function for a single-precision floating-point number.
 
 ```javascript
 var v = logitf( 0.2 );
@@ -93,11 +93,11 @@ var len = 100;
 var opts = {
     'dtype': 'float32'
 };
-var p = uniform( len, 0, 1, opts );
+var p = uniform( len, 0.0, 1.0, opts );
 var i;
 
 for ( i = 0; i < 100; i++ ) {
-    console.log( 'logitf(%f) = %f', p[ i ], logitf( p[ i ] ) );
+    console.log( 'logitf(%d) = %d', p[ i ], logitf( p[ i ] ) );
 }
 ```
 
@@ -133,14 +133,14 @@ for ( i = 0; i < 100; i++ ) {
 
 #### stdlib_base_logitf( p )
 
-Computes the [logit][logit] function for single precision-floating point number.
+Computes the [logit][logit] function for a single-precision floating-point number.
 
 ```c
-float out = stdlib_base_logitf( 0.2 );
-// returns ~-1.386
+float out = stdlib_base_logitf( 0.2f );
+// returns ~-1.386f
 
-out = stdlib_base_logitf( 0.9 );
-// returns ~2.197
+out = stdlib_base_logitf( 0.9f );
+// returns ~2.197f
 ```
 
 The function accepts the following arguments:
@@ -180,7 +180,7 @@ int main( void ) {
     int i;
 
     for ( i = 0; i < 100; i++ ) {
-        x = ( float )rand() / ( float )RAND_MAX;
+        x = (float)rand() / (float)RAND_MAX;
         v = stdlib_base_logitf( x );
         printf( "logitf(%f) = %f\n", x, v );
     }

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/benchmark/benchmark.js b/lib/node_modules/@stdlib/math/base/special/logitf/benchmark/benchmark.js
@@ -41,7 +41,7 @@ bench( pkg, function benchmark( b ) {
 	};
 
 	len = 100;
-	x = uniform( len, 0, 1, opts );
+	x = uniform( len, 0.0, 1.0, opts );
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/logitf/benchmark/benchmark.native.js
@@ -50,7 +50,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	};
 
 	len = 100;
-	x = uniform( len, 0, 1, opts );
+	x = uniform( len, 0.0, 1.0, opts );
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/benchmark/c/benchmark.c b/lib/node_modules/@stdlib/math/base/special/logitf/benchmark/c/benchmark.c
@@ -22,7 +22,7 @@
 #include <time.h>
 #include <sys/time.h>
 
-#define NAME "logit"
+#define NAME "logitf"
 #define ITERATIONS 1000000
 #define REPEATS 3
 
@@ -78,13 +78,13 @@ static double tic( void ) {
 *
 * @return random number
 */
-static double rand_double( void ) {
+static float rand_float( void ) {
 	int r = rand();
-	return (double)r / ( (double)RAND_MAX + 1.0 );
+	return (float)r / ( (float)RAND_MAX + 1.0f );
 }
 
 /**
-* Evaluates the logit function.
+* Computes the logit function for a single-precision floating-point number.
 *
 * @param x   input value
 * @return result

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/benchmark/c/native/benchmark.c b/lib/node_modules/@stdlib/math/base/special/logitf/benchmark/c/native/benchmark.c
@@ -92,8 +92,8 @@ static float rand_float( void ) {
 static double benchmark( void ) {
 	double elapsed;
 	float x[ 100 ];
-	float y;
 	double t;
+	float y;
 	int i;
 
 	for ( i = 0; i < 100; i++ ) {

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/docs/repl.txt b/lib/node_modules/@stdlib/math/base/special/logitf/docs/repl.txt
@@ -1,6 +1,6 @@
 
 {{alias}}( p )
-    Evaluates the logit function for single precision-floating point number.
+    Evaluates the logit function for a single-precision floating-point number.
 
     Let `p` be the probability of some event. The logit function is defined as
     the logarithm of the odds `p / (1-p)`.

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/logitf/examples/index.js
@@ -25,9 +25,9 @@ var len = 100;
 var opts = {
 	'dtype': 'float32'
 };
-var p = uniform( len, 0, 1, opts );
+var p = uniform( len, 0.0, 1.0, opts );
 var i;
 
 for ( i = 0; i < 100; i++ ) {
-	console.log( 'logitf(%f) = %f', p[ i ], logitf( p[ i ] ) );
+	console.log( 'logitf(%d) = %d', p[ i ], logitf( p[ i ] ) );
 }
diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/include/stdlib/math/base/special/logitf.h b/lib/node_modules/@stdlib/math/base/special/logitf/include/stdlib/math/base/special/logitf.h
@@ -27,7 +27,7 @@ extern "C" {
 #endif
 
 /**
-* Evaluates the logit function for single precision-floating point number.
+* Evaluates the logit function for a single-precision floating-point number.
 */
 float stdlib_base_logitf( const float p );
 

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/lib/index.js b/lib/node_modules/@stdlib/math/base/special/logitf/lib/index.js
@@ -19,7 +19,7 @@
 'use strict';
 
 /**
-* Evaluate the logit function for single precision-floating point number.
+* Evaluate the logit function for single-precision floating-point number.
 *
 * @module @stdlib/math/base/special/logitf
 *

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/lib/main.js b/lib/node_modules/@stdlib/math/base/special/logitf/lib/main.js
@@ -30,7 +30,7 @@ var NINF = require( '@stdlib/constants/float32/ninf' );
 // MAIN //
 
 /**
-* Evaluates the logit function for single precision-floating point number.
+* Evaluates the logit function for a single-precision floating-point number.
 *
 * @param {Probability} p - input value
 * @returns {number} function value

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/lib/native.js b/lib/node_modules/@stdlib/math/base/special/logitf/lib/native.js
@@ -26,7 +26,7 @@ var addon = require( './../src/addon.node' );
 // MAIN //
 
 /**
-* Evaluates the logit function for single precision-floating point number.
+* Evaluates the logit function for a single-precision floating-point number.
 *
 * @private
 * @param {Probability} p - input value

diff --git a/lib/node_modules/@stdlib/math/base/special/logitf/src/main.c b/lib/node_modules/@stdlib/math/base/special/logitf/src/main.c
@@ -24,14 +24,14 @@
 #include "stdlib/constants/float32/ninf.h"
 
 /**
-* Evaluates the logit function for single precision-floating point number.
+* Evaluates the logit function for a single-precision floating-point number.
 *
 * @param x    input value
-* @return	  output value
+* @return     output value
 *
 * @example
-* float out = stdlib_base_logitf( 0.2 );
-* // returns ~-1.386
+* float out = stdlib_base_logitf( 0.2f );
+* // returns ~-1.386f
 */
 float stdlib_base_logitf( const float p ) {
 	if ( stdlib_base_is_nanf( p ) ) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,7 +27,7 @@ extern "C" { @@
     #endif
     /**
-    * Evaluates the logit function for single precision-floating point number.
+    * Evaluates the logit function for a single-precision floating-point number.
     */
     float stdlib_base_logitf( const float p );
@@ Expand Down @@