Skip to content

Refactor SOTU dataset package #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Sep 16, 2016
Merged

Refactor SOTU dataset package #4

merged 28 commits into from
Sep 16, 2016

Conversation

kgryte
Copy link
Member

@kgryte kgryte commented Sep 16, 2016

This PR:

  • refactors the SOTU dataset pkg
  • adds a CLI
  • updates FAQ

kgryte added 24 commits September 13, 2016 22:14
@kgryte
Update license and update test case
edbc115
@kgryte
Refactor implementation and add year support
9c289c8
@kgryte
Remove unused files and add script to generate JSON files
bbd2c09
@kgryte
Lowercase none
181c063
@kgryte
Replace HTML escaped chars, add build script, and add JSON data files
09dd9eb
@kgryte
Generate a browser virtual file list, add tests, and fix file name
1464bf0
@kgryte
Update license terms and update README
942e6ce
@kgryte
Add build step to autogenerate datapackage resources
9c61626
@kgryte
Add integer array type defs
f1e54e2
@kgryte
Add CLI
0109fec
@kgryte
Update items
48996c4
@kgryte
Update grammar
faae7b7
@kgryte
Fix example
edae0b9
@kgryte
Fix broken links
1e3a5ce
@kgryte
Fix misspelled word
0bb06c7
@kgryte
Add missing type annotation
7be5f23
@kgryte
Fix examples
a806933
@kgryte
Add note about US copyright law
0b83474
@kgryte
Add questions and answers
6e662b3
@kgryte
Add link
fd9ca65
@kgryte
Fix capitalization
3d1d73a
@kgryte
Fix grammar
397573f
@kgryte
Fix WebAssembly
7dc0d5a
@kgryte
Update items
18dbf9b
@Planeshifter Planeshifter self-assigned this Sep 16, 2016
@kgryte kgryte added the Needs Review A pull request which needs code review. label Sep 16, 2016
@Planeshifter
Copy link
Member

Looks all good to merge. Merge?

@codecov-io
Copy link

Current coverage is 86.2240% (diff: 100%)

Merging #4 into develop will increase coverage by 0.1673%

@@            develop         #4   diff @@
==========================================
  Files          1734       1744    +10   
  Lines         24614      24913   +299   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          21182      21481   +299   
  Misses         3432       3432          
  Partials          0          0

Sunburst

Powered by Codecov. Last update 30dfdf7...18dbf9b

@kgryte
Copy link
Member Author

kgryte commented Sep 16, 2016

@Planeshifter Thanks for reviewing!

@kgryte kgryte merged commit f972154 into develop Sep 16, 2016
@kgryte kgryte deleted the feature/sotu branch September 20, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Planeshifter Planeshifter

Labels
Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgryte @Planeshifter @codecov-io