Skip to content
/ stdlib Public

  • Sponsor stdlib-js/stdlib

  • Notifications You must be signed in to change notification settings
  • Fork 814
  • Star 5.1k

feat: add C implementation of stats/dists/gumbel/logpdf #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2025
Merged

feat: add C implementation of stats/dists/gumbel/logpdf #4085

merged 6 commits into from
Apr 24, 2025
+1,395 −1

Conversation

Vinit-Pandit
Copy link
Contributor

Resolves #3647 .

Description

What is the purpose of this pull request?

This pull request:

  • add c implementation of stats/dists/gumbel/logpdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers
PHP-Proxy

PHP-Proxy

Error accessing resource: 404 - Not Found

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 20, 2024
@Vinit-Pandit Vinit-Pandit marked this pull request as draft December 20, 2024 07:44
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 20, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 20, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/gumbel/logpdf $\color{green}298/298$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}298/298$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Vinit-Pandit
fix: declaring Undeclared variable y in readme
7ee116c 
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
@Vinit-Pandit Vinit-Pandit marked this pull request as ready for review December 20, 2024 08:58
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 20, 2024
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@Planeshifter Planeshifter changed the title feat: add c implementation of stats/dists/gumbel/logpdf feat: add C implementation of stats/dists/gumbel/logpdf Feb 24, 2025
@Planeshifter
Merge branch 'develop' into stats/base/dists/gumbel/logpdf
eb257f7 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 24, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 24, 2025
@Vinit-Pandit
style: removing trailing whitespaces
6291277 
Signed-off-by: Vinit Pandit <106718914+Vinit-Pandit@users.noreply.github.com>
Planeshifter
Planeshifter previously approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Vinit-Pandit!

@Planeshifter
chore: apply suggestions from code review
3b2313f 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 24, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 24, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 24, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation of `stats/dists/gumbel/logpdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4085
Closes: https://github.com/stdlib-js/stdlib/issues/3647

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Vinit Pandit <vinitsharma2480@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Signed-off-by: Vinit Pandit <106718914+Vinit-Pandit@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit a92a6e3 into stdlib-js:develop Apr 24, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/gumbel/logpdf
3 participants
@Vinit-Pandit @stdlib-bot @Planeshifter