feat: add math/base/special/ceilnf
#4107
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neerajpathak07
commented
Jan 28, 2025
| } | ||
| // If we overflow, return `x`, as the number of digits to the right of the decimal is too small (i.e., `x` is too large / lacks sufficient fractional precision) for there to be any effect when rounding... | ||
| if ( n < STDLIB_CONSTANT_FLOAT32_MIN_BASE10_EXPONENT ) { | ||
| s = stdlib_base_pow( 10.0f, -( n + STDLIB_CONSTANT_FLOAT32_MAX_BASE10_EXPONENT ) ); // TODO: replace use of `pow` once have stdlib equivalent |
There was a problem hiding this comment.
will either use stdlib_base_exp2f for which I'll have to wait for the PR on it to be merged or add implementations for powf then update this again.
The test cases are failing as the ranges exceed the float limit upon deriving the values after pow().
Neerajpathak07
commented
Jan 28, 2025
| // VARIABLES // | ||
|
|
||
| static const float MAX_INT = STDLIB_CONSTANT_FLOAT32_MAX_SAFE_INTEGER + 1.0f; | ||
| static const float HUGE_VALUE = 1.0e+38f; |
There was a problem hiding this comment.
adjusted the range to suit float operations!!
|
/stdlib update-copyright-years |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #649 .
Description
This pull request:
math/base/special/ceilnfRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers