Skip to content

feat: add C implementation for stats/base/dists/erlang/entropy #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 5, 2025
Merged

feat: add C implementation for stats/base/dists/erlang/entropy #4263

merged 21 commits into from
Apr 5, 2025

Conversation

Neerajpathak07
Copy link
Contributor

Resolves #3569 .

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/erlang/entropy

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 26, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 26, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/erlang/entropy $\color{green}202/202$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}202/202$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 30, 2024 08:36
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 30, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 16, 2025 16:05
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025
@Neerajpathak07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 17, 2025 19:35
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 17, 2025
@Neerajpathak07
Copy link
Contributor Author

Neerajpathak07 commented Feb 24, 2025 •
edited
Loading

@Planeshifter could you please take a look at this will be able to check off issues on stats/base/dists/erlang

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 2, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft March 15, 2025 19:09
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 15, 2025
@Neerajpathak07 Neerajpathak07 mentioned this pull request Apr 3, 2025
Merged
1 task
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review April 3, 2025 17:54
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 3, 2025
@Planeshifter Planeshifter self-requested a review April 5, 2025 02:46
@Planeshifter
chore: apply suggestions from code review
f02f72b 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Neerajpathak07!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/erlang/entropy`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4263
Closes: https://github.com/stdlib-js/stdlib/issues/3569

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit e4185d6 into stdlib-js:develop Apr 5, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/erlang/entropy
3 participants
@Neerajpathak07 @stdlib-bot @Planeshifter