Skip to content

feat: add C implementation for stats/base/dists/logistic/quantile #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 6, 2025
Merged

feat: add C implementation for stats/base/dists/logistic/quantile #4352

merged 8 commits into from
Apr 6, 2025

Conversation

DhruvArvindSingh
Copy link
Contributor

Resolves #3743 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds C implementation for @stdlib/stats/base/dists/logistic/quantile

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@DhruvArvindSingh
feat: add c implementation for @stdlib/stats/base/dists/logistic/quan…
d01fe8d 
…tile

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 29, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 29, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/logistic/quantile $\color{green}295/295$
$\color{green}+100.00\%$ 		$\color{green}27/27$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}295/295$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Merge branch 'develop' into develop_#3743
586c50d 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. bot: In Progress Pull request is currently awaiting automation. labels Apr 6, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 6, 2025
@Planeshifter Planeshifter changed the title feat: add c implementation for @stdlib/stats/base/dists/logistic/quantile feat: add c implementation for stats/base/dists/logistic/quantile Apr 6, 2025
@Planeshifter Planeshifter changed the title feat: add c implementation for stats/base/dists/logistic/quantile feat: add C implementation for stats/base/dists/logistic/quantile Apr 6, 2025
@Planeshifter
chore: apply suggestions from code review
e2d6069 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
chore: apply suggestions from code review
ca43921 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
docs: add empty lines
c359a80
@Planeshifter
bench: replace randu with uniform in benchmark
b63af25
Planeshifter
Planeshifter previously approved these changes Apr 6, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once CI checks have all passed.

@Planeshifter
chore: apply suggestions from code review
35ebdcc 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 6, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 6, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/logistic/quantile`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4352
Closes: https://github.com/stdlib-js/stdlib/issues/3743

Co-authored-by: DhruvArvindSingh <dhruvsinghxd@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 1239d3e into stdlib-js:develop Apr 6, 2025
30 checks passed
@DhruvArvindSingh DhruvArvindSingh mentioned this pull request Apr 7, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/logistic/quantile
3 participants
@DhruvArvindSingh @stdlib-bot @Planeshifter