Skip to content

feat: add C implementation for stats/base/dists/chi/mean #4514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 30, 2025
Merged

feat: add C implementation for stats/base/dists/chi/mean #4514

merged 8 commits into from
Apr 30, 2025

Conversation

AadishJ
Copy link
Contributor

@AadishJ AadishJ commented Jan 3, 2025

Resolves #3493.

Description

What is the purpose of this pull request?

This pull request:

  • Adds a C implementation of the chi mean.
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the chi mean in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 3, 2025
@AadishJ
Copy link
Contributor Author

AadishJ commented Jan 3, 2025

/stdlib update-copyright-years

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 3, 2025 •
edited
Loading

Coverage Report

No coverage information available.

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@stdlib-bot
Copy link
Contributor

@AadishJ, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@AadishJ
Update benchmark.js
63aedc8 
Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>
This was referenced Jan 5, 2025
Draft
Draft
@Planeshifter Planeshifter self-requested a review April 30, 2025 01:10
@Planeshifter
Merge branch 'develop' into develop12
219cde0 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 30, 2025
@Planeshifter
chore: apply suggestions from code review
647276b 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
docs: use full description in README
3e65911 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
chore: update example printout
44ef1e2 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
bench: use uniform instead of randu
3919413 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AadishJ! Will merge once all CI checks show up as green.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 30, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 30, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/chi/mean`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4514
Closes: https://github.com/stdlib-js/stdlib/issues/3493

Co-authored-by: Aadish Jain <firestorm@AadishJain.>
Co-authored-by: Aadish Jain <jain.aadishj@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 9e43626 into stdlib-js:develop Apr 30, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/chi/mean
3 participants
@AadishJ @stdlib-bot @Planeshifter