feat: add javascript implementation of `blas/base/cdotc` #4752

Vinit-Pandit · 2025-01-14T14:01:45Z

Progress #2039

Description

What is the purpose of this pull request?

This pull request:

add javascript implementation of blas/base/cdotc

Related Issues

Does this pull request have any related issues?

This pull request:

progress [RFC]: Add BLAS bindings and implementations for linear algebra (tracking issue) #2039

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-01-14T14:03:33Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/base/cdotc	$\color{green}281/281$ $\color{green}+100.00\%$	$\color{green}14/14$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}281/281$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: failed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

Vinit-Pandit · 2025-01-14T14:31:35Z

/stdlib update-copyright-years

Vinit-Pandit · 2025-01-14T15:00:06Z

/stdlib --help

stdlib-bot · 2025-01-14T15:00:20Z

@MeastroZI, slash command not recognized. Please use /stdlib help to view available commands.

Vinit-Pandit · 2025-01-14T15:00:59Z

/stdlib help

stdlib-bot · 2025-01-14T15:01:20Z

@MeastroZI, available slash commands include:

/stdlib check-files - Check for required files.
/stdlib update-copyright-years - Update copyright header years.
/stdlib lint-autofix - Auto-fix lint errors.
/stdlib merge - Merge changes from develop branch into this PR.
/stdlib rebase - Rebase this PR on top of develop branch.

Vinit-Pandit · 2025-01-16T03:38:15Z

@kgryte have one look on the benchmark i.e : here , the way i have checked to nan value for the complex weather it is correct or no .

ShabiShett07 · 2025-04-28T09:13:32Z

lib/node_modules/@stdlib/blas/base/cdotc/lib/index.js

+
+module.exports = cdotc;
+
+// exports: { "ndarray": "sdot.ndarray" }


Suggested change

// exports: { "ndarray": "sdot.ndarray" }

// exports: { "ndarray": "cdotc.ndarray" }

ShabiShett07 · 2025-04-28T11:48:27Z

lib/node_modules/@stdlib/blas/base/cdotc/docs/repl.txt

+    > var re = {{alias:@stdlib/complex/float32/real}}( out )
+    54
+    > var im = {{alias:@stdlib/complex/float32/imag}}( out )
+    -80


Suggested change

> var re = {{alias:@stdlib/complex/float32/real}}( out )

54

> var im = {{alias:@stdlib/complex/float32/imag}}( out )

-80

<Complex64>[ 54, -80 ]

ShabiShett07 · 2025-04-28T11:50:14Z

lib/node_modules/@stdlib/blas/base/cdotc/lib/ndarray.js

+* var realf = require( '@stdlib/complex/float32/real' );
+* var imagf = require( '@stdlib/complex/float32/imag' );
+*
+* var x = new Complex64Array( [ 7.0, -8.0, -1.0, -9.0 ] );
+* var y = new Complex64Array( [ 6.0, -6.0, -9.0, 5.0 ] );
+*
+* var out = cdotc( x.length, x, 1, 0, y, 1, 0 );
+* // returns <Complex64>
+*
+* var re = realf( out );
+* // returns 54
+*
+* var im = imagf( out );
+* // returns -80


Suggested change

* var realf = require( '@stdlib/complex/float32/real' );

* var imagf = require( '@stdlib/complex/float32/imag' );

*

* var x = new Complex64Array( [ 7.0, -8.0, -1.0, -9.0 ] );

* var y = new Complex64Array( [ 6.0, -6.0, -9.0, 5.0 ] );

*

* var out = cdotc( x.length, x, 1, 0, y, 1, 0 );

* // returns <Complex64>

*

* var re = realf( out );

* // returns 54

*

* var im = imagf( out );

* // returns -80

*

* var x = new Complex64Array( [ 7.0, -8.0, -1.0, -9.0 ] );

* var y = new Complex64Array( [ 6.0, -6.0, -9.0, 5.0 ] );

*

* var out = cdotc( x.length, x, 1, 0, y, 1, 0 );

* // returns <Complex64>[ 54, -80 ]

ShabiShett07 · 2025-04-28T14:19:30Z

lib/node_modules/@stdlib/blas/base/cdotc/examples/index.js

+	return new Complex64( discreteUniform( 0, 10 ), discreteUniform( 1, 5 ) );
+}
+
+var cx = filledarrayBy( 10, 'complex64', rand );


Could you please change cx to x as well as cy to y here and elsewhere?

kgryte · 2025-04-29T01:39:10Z

lib/node_modules/@stdlib/blas/base/cdotc/benchmark/benchmark.js

+		b.tic();
+		for ( i = 0; i < b.iterations; i++ ) {
+			out = cdotc( cx.length, cx, 1, cy, 1 );
+			if ( isnanf( realf( out ) ) || isnanf( imagf( out ) )) {


Suggested change

if ( isnanf( realf( out ) ) || isnanf( imagf( out ) )) {

if ( isnanf( realf( out ) ) ) {

You only need to check one component for the purposes of this benchmark.

kgryte · 2025-04-29T01:39:24Z

lib/node_modules/@stdlib/blas/base/cdotc/benchmark/benchmark.js

+			}
+		}
+		b.toc();
+		if ( isnanf( realf( out ) ) || isnanf( imagf( out ) )) {


Suggested change

if ( isnanf( realf( out ) ) || isnanf( imagf( out ) )) {

if ( isnanf( realf( out ) ) || isnanf( imagf( out ) ) ) {

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Jan 14, 2025

Vinit-Pandit marked this pull request as draft January 14, 2025 14:02

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 14, 2025

Vinit-Pandit added 4 commits January 14, 2025 14:09

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025

chore: update copyright years

ff192a2

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025

Vinit-Pandit marked this pull request as ready for review January 14, 2025 15:20

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 14, 2025

Vinit-Pandit mentioned this pull request Apr 7, 2025

[RFC]: adding support for visualizing benchmark results stdlib-js/google-summer-of-code#146

Open

7 tasks

ShabiShett07 reviewed Apr 28, 2025

View reviewed changes

kgryte reviewed Apr 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add javascript implementation of `blas/base/cdotc` #4752

feat: add javascript implementation of `blas/base/cdotc` #4752

Vinit-Pandit commented Jan 14, 2025

stdlib-bot commented Jan 14, 2025 •

edited

Loading

Vinit-Pandit commented Jan 14, 2025

Vinit-Pandit commented Jan 14, 2025

stdlib-bot commented Jan 14, 2025

Vinit-Pandit commented Jan 14, 2025

stdlib-bot commented Jan 14, 2025

Vinit-Pandit commented Jan 16, 2025

ShabiShett07 Apr 28, 2025

ShabiShett07 Apr 28, 2025

ShabiShett07 Apr 28, 2025

ShabiShett07 Apr 28, 2025 •

edited

Loading

kgryte Apr 29, 2025

kgryte Apr 29, 2025


		module.exports = cdotc;

		// exports: { "ndarray": "sdot.ndarray" }

	// exports: { "ndarray": "sdot.ndarray" }
	// exports: { "ndarray": "cdotc.ndarray" }

	if ( isnanf( realf( out ) ) \|\| isnanf( imagf( out ) )) {
	if ( isnanf( realf( out ) ) ) {

feat: add javascript implementation of blas/base/cdotc #4752

Are you sure you want to change the base?

feat: add javascript implementation of blas/base/cdotc #4752

Conversation

Vinit-Pandit commented Jan 14, 2025

Description

Related Issues

Questions

Other

Checklist

stdlib-bot commented Jan 14, 2025 • edited Loading

Coverage Report

Vinit-Pandit commented Jan 14, 2025

Vinit-Pandit commented Jan 14, 2025

stdlib-bot commented Jan 14, 2025

Vinit-Pandit commented Jan 14, 2025

stdlib-bot commented Jan 14, 2025

Vinit-Pandit commented Jan 16, 2025

ShabiShett07 Apr 28, 2025

Choose a reason for hiding this comment

ShabiShett07 Apr 28, 2025

Choose a reason for hiding this comment

ShabiShett07 Apr 28, 2025

Choose a reason for hiding this comment

ShabiShett07 Apr 28, 2025 • edited Loading

Choose a reason for hiding this comment

kgryte Apr 29, 2025

Choose a reason for hiding this comment

kgryte Apr 29, 2025

Choose a reason for hiding this comment

feat: add javascript implementation of `blas/base/cdotc` #4752

feat: add javascript implementation of `blas/base/cdotc` #4752

stdlib-bot commented Jan 14, 2025 •

edited

Loading

ShabiShett07 Apr 28, 2025 •

edited

Loading