feat: add C implementation for `lapack/base/dlacpy` #5210

0PrashantYadav0 · 2025-02-13T11:15:07Z

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

add c implementation for dlacpy

Related Issues

Does this pull request have any related issues?

This pull request:

resolves None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

0PrashantYadav0 · 2025-02-13T11:16:30Z

/stdlib update-copyright-years

stdlib-bot · 2025-02-13T11:16:41Z

Coverage Report

Package	Statements	Branches	Functions	Lines
lapack/base/dlacpy	$\color{green}950/950$ $\color{green}+100.00\%$	$\color{green}47/47$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}950/950$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

…ectories --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

…unctions --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

0PrashantYadav0 · 2025-03-01T07:10:58Z

@kgryte Please review this pr if possible. thank you.

lib/node_modules/@stdlib/lapack/base/dlacpy/README.md

Signed-off-by: Athan <kgryte@gmail.com>

kgryte · 2025-03-15T02:22:16Z

lib/node_modules/@stdlib/lapack/base/dlacpy/src/dlacpy.c

+* @param strideB2  stride of the second dimension of `B`
+* @param offsetB   starting index for `B`
+*/
+void API_SUFFIX(c_copy_all)( const CBLAS_INT M, const CBLAS_INT N, const double *A, const CBLAS_INT strideA1, const CBLAS_INT strideA2, const CBLAS_INT offsetA, double *B, const CBLAS_INT strideB1, const CBLAS_INT strideB2, const CBLAS_INT offsetB ) {


These should be private functions. Right now, you are exposing them outside the translation unit. That is not desired.

lib/node_modules/@stdlib/lapack/base/dlacpy/src/dlacpy.c

kgryte · 2025-03-15T02:23:49Z

lib/node_modules/@stdlib/lapack/base/dlacpy/src/dlacpy.c

+	}
+
+	for ( i1 = 0; i1 < N; i1++ ) {
+		for ( i0 = 0; i0 <= stdlib_base_fast_min( i1, M-1 ); i0++ ) {


You shouldn't be using fast_min. That is for doubles. Instead, either define an internal function or a macro for returning the min of two integers.

kgryte · 2025-03-15T02:24:01Z

lib/node_modules/@stdlib/lapack/base/dlacpy/src/dlacpy.c

+	ib = offsetB;
+	if ( stdlib_ndarray_is_row_major( 2, strides ) ) {
+		for ( i1 = 0; i1 < M; i1++ ) {
+			for ( i0 = 0; i0 <= stdlib_base_fast_min( i1, N-1 ); i0++ ) {


Same thing.

kgryte · 2025-03-15T02:24:38Z

lib/node_modules/@stdlib/lapack/base/dlacpy/src/dlacpy.c

+#include "stdlib/lapack/base/dlacpy.h"
+#include "stdlib/blas/base/shared.h"
+#include "stdlib/strided/base/stride2offset.h"
+#include "stdlib/math/base/special/fast/min.h"


You shouldn't be using this API.

kgryte · 2025-03-15T02:26:48Z

lib/node_modules/@stdlib/lapack/base/dlacpy/src/dlacpy.c

+		sb2 = LDB;
+	} else { // order === 'row-major'
+		if ( LDA < N ) {
+			return;


This is wrong. You should be using xerbla. The JS implementation raises exceptions. That follows BLAS/LAPACK. We should do the same here.

kgryte · 2025-03-15T02:27:41Z

lib/node_modules/@stdlib/lapack/base/dlacpy/src/dlacpy.c

+/**
+* Copies all or part of a matrix `A` to another matrix `B` using alternative indexing semantics.
+*
+* @private


Suggested change

* @private

Why is this annotation here?

kgryte · 2025-03-15T02:28:07Z

lib/node_modules/@stdlib/lapack/base/dlacpy/src/dlacpy.c

+* @param M        number of rows in matrix `A`
+* @param N        number of columns in matrix `A`
+* @param A        input matrix
+* @param strideA1 stride of the first dimension of `A`


Prefer at least two spaces between a parameter and its description. Will require re-aligning all descriptions.

kgryte · 2025-03-15T02:28:51Z

lib/node_modules/@stdlib/lapack/base/dlacpy/src/dlacpy.c

+*/
+void API_SUFFIX(c_dlacpy_ndarray)( const CBLAS_UPLO uplo, const CBLAS_INT M, const CBLAS_INT N, const double *A, const CBLAS_INT strideA1, const CBLAS_INT strideA2, const CBLAS_INT offsetA, double *B, const CBLAS_INT strideB1, const CBLAS_INT strideB2, const CBLAS_INT offsetB ) {
+	if ( uplo == CblasUpper ) {
+		c_copy_upper( M, N, A, strideA1, strideA2, offsetA, B, strideB1, strideB2, offsetB );


If you are wrapping c_copy_upper in API_SUFFIX, you need to do the same here. Applies below, as well.

lib/node_modules/@stdlib/lapack/base/dlacpy/src/addon.c

lib/node_modules/@stdlib/lapack/base/dlacpy/README.md

kgryte · 2025-03-15T02:35:01Z

lib/node_modules/@stdlib/lapack/base/dlacpy/README.md

-TODO
+#include "stdlib/blas/base/shared.h"
+
+double A[] = { 1.0, 2.0, 3.0, 4.0 };


Suggested change

double A[] = { 1.0, 2.0, 3.0, 4.0 };

const double A[] = { 1.0, 2.0, 3.0, 4.0 };

This array is not mutated. Applies here and below.

kgryte · 2025-03-15T02:35:23Z

lib/node_modules/@stdlib/lapack/base/dlacpy/README.md

+```c
+#include "stdlib/blas/base/shared.h"
+
+double A[] = { 1.0, 2.0, 3.0, 4.0, 5.0 };


Why do these arrays have an odd number of elements?

lib/node_modules/@stdlib/lapack/base/dlacpy/README.md

kgryte

Left initial comments. As a general comment, you need to pay more attention to detail when submitting PRs. At this point, you've made over 130 PRs to the project, and I'd expect a higher level of quality.

0PrashantYadav0 · 2025-03-15T10:20:04Z

@kgryte Thank you for your review. I will make sure to pay more attention to details as well as improve the quality of pr even more. As i open this pr way back it have some issues i will resolve them soon.

kgryte · 2025-04-30T02:23:18Z

@0PrashantYadav0 Are you planning on updating this PR or should we close this out?

stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. labels Feb 13, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 13, 2025

chore: update copyright years

888933c

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 13, 2025

0PrashantYadav0 marked this pull request as draft February 13, 2025 11:25

stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 13, 2025

0PrashantYadav0 added 4 commits February 13, 2025 18:52

0PrashantYadav0 marked this pull request as ready for review February 13, 2025 14:45

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 13, 2025

0PrashantYadav0 changed the title ~~feat: added C implementation for lapack/base/dlacpy~~ feat: add C implementation for lapack/base/dlacpy Feb 13, 2025

kgryte self-requested a review March 15, 2025 02:10