Skip to content

feat: add stats/base/dists/burr-type3/cdf #5916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

feat: add stats/base/dists/burr-type3/cdf #5916

wants to merge 7 commits into from
+1,562 −0

Conversation

vivekmaurya001
Copy link
Contributor

Progresses #169.

This pull request:

  • add stats/base/dists/burr-type3/cdf

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@vivekmaurya001
feat: add stats/base/dists/burr-type3/cdf
380e8ea 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: passed
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Mar 9, 2025
@vivekmaurya001 vivekmaurya001 marked this pull request as draft March 9, 2025 07:44
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 9, 2025
@vivekmaurya001
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 9, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 9, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 9, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/burr-type3/cdf $\color{green}230/230$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}230/230$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001
feat: add stats/base/dists/burr-type3/cdf
bd1e67c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@vivekmaurya001
Merge branch 'burr-type3/cdf' of https://github.com/vivekmaurya001/st…
0d7f2e6 
…dlib into burr-type3/cdf
@vivekmaurya001
feat: add stats/base/dists/burr-type3/cdf
6fce82f
@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review March 16, 2025 05:41
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 16, 2025
@vivekmaurya001 vivekmaurya001 mentioned this pull request Mar 26, 2025
Open
7 tasks
@kgryte kgryte requested a review from Planeshifter April 16, 2025 00:15
@Planeshifter
docs: use available width of 80 chars
43fcdf5 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter reviewed Apr 30, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/burr-type3/cdf/README.md
Comment on lines +37 to +40
<!-- <div class="equation" align="center" data-raw-text="F(x;c,d) = (1 + x^{-c})^{-d}" data-equation="eq:burr-type3_cdf">
<img src="https://quicklatex.com/cache3/1e/ql_96e6c56a3c01ce5db3f378b28ee9511e_l3.png" alt="Cumulative distribution function for a Burr (Type III) distribution.">
<br>
</div> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this as it will be auto-generated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ook

Planeshifter
Planeshifter requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

However, instead of alpha and beta, I am thinking we should change paramater names to c and d as in the SciPy documentation. Or are alpha and beta used anywhere in the literature or other libraries as parameter names for this distribution?

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 30, 2025
@vivekmaurya001
Copy link
Contributor Author

Yes , In my other burr dist PR's I have taken parameters as alpha and beta
I will change them as c and d soon !

@vivekmaurya001 vivekmaurya001 marked this pull request as draft April 30, 2025 07:37
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivekmaurya001 @stdlib-bot @Planeshifter @kgryte