Skip to content

bench: rename randu to uniform for consistency #6043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

bench: rename randu to uniform for consistency #6043

merged 1 commit into from
Apr 30, 2025

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 14, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Replaces randu() with uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 14, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/gamma $\color{red}547/556$
$\color{green}+98.38\%$ 		$\color{red}48/52$
$\color{green}+92.31\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{red}547/556$
$\color{green}+98.38\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 30, 2025
@kgryte kgryte changed the title chore: update randu to uniform for consistency bench: rename randu to uniform for consistency Apr 30, 2025
@kgryte kgryte added the Benchmarks Pull requests adding or improving benchmarks for measuring performance. label Apr 30, 2025
@kgryte
Copy link
Member

kgryte commented Apr 30, 2025

As this CI failure doesn't stem from changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte merged commit 9349867 into stdlib-js:develop Apr 30, 2025
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Benchmarks Pull requests adding or improving benchmarks for measuring performance. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrshya @stdlib-bot @kgryte