Skip to content

feat: add stats/incr/nanmaxabs #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 29, 2025
Merged

feat: add stats/incr/nanmaxabs #6116

merged 6 commits into from
Apr 29, 2025

Conversation

Girish-Garg
Copy link
Contributor

Resolves #5566.

Description

What is the purpose of this pull request?

This pull request:

  • add incremental maximum absolute value accumulator ignoring NaN values by making warpper of stats/incr/maxabs main accumulator function

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Tests:
image
Examples:
image
benchmark:
image

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 17, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 17, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmaxabs $\color{green}134/134$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}134/134$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Girish-Garg Girish-Garg mentioned this pull request Mar 22, 2025
Open
7 tasks
@Girish-Garg Girish-Garg changed the title feat: add incremental maximum absolute value accumulator ignoring NaN values feat: add stats/incr/maxabs Apr 16, 2025
@Girish-Garg Girish-Garg changed the title feat: add stats/incr/maxabs feat: add stats/incr/nanmaxabs Apr 18, 2025
@Girish-Garg
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 23, 2025
@Girish-Garg
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 23, 2025
@stdlib-bot
Copy link
Contributor

/stdlib lint-autofix

@Girish-Garg, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@kgryte
Copy link
Member

kgryte commented Apr 29, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 29, 2025
@kgryte kgryte self-requested a review April 29, 2025 07:41
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 29, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 29, 2025
@kgryte
chore: clean-up
2d89481 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Girish-Garg This LGTM after clean-up. You'll want to apply changes similar to those I made in this PR to your other stats/incr PRs.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 29, 2025
@kgryte kgryte merged commit 76f65a5 into stdlib-js:develop Apr 29, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmaxabs
3 participants
@Girish-Garg @stdlib-bot @kgryte