Skip to content

chore: fix EditorConfig lint errors (issue #6552) #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 5, 2025
Merged

chore: fix EditorConfig lint errors (issue #6552) #6569

merged 5 commits into from
Apr 5, 2025

Conversation

dipexplorer
Copy link
Contributor

@dipexplorer dipexplorer commented Apr 5, 2025 •
edited
Loading

Resolves #6552.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes an EditorConfig linting error by replacing tabs with spaces in bad_confs4.json.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@dipexplorer
fix Editor Config lint errors (issue #6552)
72abfa9 
Signed-off-by: Dipjyoti Das <126075231+dipexplorer@users.noreply.github.com>
@dipexplorer
fix EditorConfig in bad_confs4.json
38049f6 
Signed-off-by: Dipjyoti Das <126075231+dipexplorer@users.noreply.github.com>
@dipexplorer
Merge pull request #2 from dipexplorer/fix-editorconfig-6552
7eb9b10 
fix EditorConfig in bad_confs4.json
@dipexplorer
Merge pull request #1 from dipexplorer/fix-editorconfig-issue-6552
632fa6d 
fix Editor Config lint errors (issue #6552)
@dipexplorer
Revert "fix Editor Config lint errors (issue #6552)"
fc0581d
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Apr 5, 2025
stdlib-bot
stdlib-bot reviewed Apr 5, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@dipexplorer dipexplorer changed the title Revert 1 fix editorconfig issue 6552 fix EditorConfig lint errors (issue #6552) Apr 5, 2025
@dipexplorer dipexplorer changed the title fix EditorConfig lint errors (issue #6552) chore: fix EditorConfig lint errors (issue #6552) Apr 5, 2025
Planeshifter
Planeshifter approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: fix EditorConfig lint errors (issue #6552)

PR-URL: https://github.com/stdlib-js/stdlib/pull/6569
Closes: https://github.com/stdlib-js/stdlib/issues/6552

Co-authored-by: Dipjyoti Das <126075231+dipexplorer@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Dipjyoti Das <126075231+dipexplorer@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 9452b23 into stdlib-js:develop Apr 5, 2025
107 of 109 checks passed
@dipexplorer dipexplorer mentioned this pull request Apr 6, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Tools Issue or pull request related to project tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
3 participants
@dipexplorer @stdlib-bot @Planeshifter