Skip to content

bench: update random value generation #6691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

bench: update random value generation #6691

merged 2 commits into from
Apr 15, 2025

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Apr 15, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the math/base/assert/is-positive-zerof, math/base/assert/is-probability, and math/base/assert/is-probabilityf packages.
  • Replaces randu() with uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Updates the test messages to follow code conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Apr 15, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 15, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/assert/is-positive-zerof $\color{green}143/143$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}143/143$
$\color{green}+100.00\%$
math/base/assert/is-probability $\color{green}147/147$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}147/147$
$\color{green}+100.00\%$
math/base/assert/is-probabilityf $\color{green}147/147$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}147/147$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@hrshya
update benchmark.native.js
112e55c 
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
Planeshifter
Planeshifter approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 15, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 15, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

bench: update random value generation

PR-URL: https://github.com/stdlib-js/stdlib/pull/6691

Co-authored-by: Harsh <149176984+hrshya@users.noreply.github.com>
Co-authored-by: hrshya <harshyadav6078@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 65f0948 into stdlib-js:develop Apr 15, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrshya @stdlib-bot @Planeshifter