feat: add ndarray/concat
#7969
Draft
feat: add ndarray/concat
#7969
+1,455
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to merge #7853 first. |
kgryte
reviewed
Sep 7, 2025
| * Concatenates a list of ndarrays along a specified ndarray dimension. | ||
| * | ||
| * @param {ArrayLikeObject<Object>} arrays - array-like object containing input ndarrays | ||
| * @param {integer} dim - dimension along which the arrays are concatenated |
There was a problem hiding this comment.
This needs to be a negative integer and should be validated as such.
kgryte
reviewed
Sep 7, 2025
| N = arrays.length; | ||
| arrs = []; | ||
| if ( N < 1 ) { | ||
| throw new RangeError( format( 'invalid argument. First argument must have more than one ndarray. Value: `%s`.', N ) ); |
There was a problem hiding this comment.
Suggested change
| throw new RangeError( format( 'invalid argument. First argument must have more than one ndarray. Value: `%s`.', N ) ); | |
| throw new RangeError( format( 'invalid argument. First argument must have one or more ndarrays. Value: `%s`.', N ) ); |
kgryte
reviewed
Sep 7, 2025
| * @param {ArrayLikeObject<Object>} arrays - array-like object containing input ndarrays | ||
| * @param {integer} dim - dimension along which the arrays are concatenated | ||
| * @throws {TypeError} first argument must be an array of ndarray-like objects | ||
| * @throws {RangeError} first argument must have more than one ndarray |
kgryte
reviewed
Sep 7, 2025
| orders = []; | ||
| for ( i = 0; i < N; i++ ) { | ||
| if ( !isndarrayLike( arrays[ i ] ) ) { | ||
| throw new TypeError( format( 'invalid argument. First argument must be an array of ndarray-like objects. Value: `%s`.', arrays[ i ] ) ); |
There was a problem hiding this comment.
Suggested change
| throw new TypeError( format( 'invalid argument. First argument must be an array of ndarray-like objects. Value: `%s`.', arrays[ i ] ) ); | |
| throw new TypeError( format( 'invalid argument. First argument must be an array of ndarrays. Value: `%s`.', arrays[ i ] ) ); |
kgryte
reviewed
Sep 7, 2025
| throw new RangeError( format( 'invalid argument. Output ndarray must have %d dimensions. Value: %d.', sh.length, getShape( out ).length ) ); | ||
| } | ||
| for ( i = 0; i < sh.length; i++ ) { | ||
| if ( getShape( out )[ i ] !== sh[ i ] ) { |
There was a problem hiding this comment.
You should not be calling getShape repeatedly like this. You're materializing a new shape array for every call.
kgryte
reviewed
Sep 7, 2025
| if ( getDtype( out ) !== dt ) { | ||
| throw new TypeError( format( 'invalid argument. Output ndarray must have a dtype of `%s`. Value: `%s`.', dt, getDtype( out ) ) ); | ||
| } | ||
| if ( getOrder( out ) !== ord ) { |
There was a problem hiding this comment.
Why is it necessary for the output array to have the resolved order?
kgryte
reviewed
Sep 7, 2025
| } | ||
| ord = resolveOutputOrder( orders ); | ||
| if ( out ) { | ||
| if ( getDtype( out ) !== dt ) { |
There was a problem hiding this comment.
Why is it necessary for the output array to have the promoted data type?
|
/stdlib merge |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #2656.
Description
This pull request:
ndarray/concatRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers