Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Update documentation to include Protocol 19 features #673

Merged
merged 21 commits into from
May 6, 2022
Merged

Update documentation to include Protocol 19 features #673

merged 21 commits into from
May 6, 2022

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Apr 27, 2022

Note: This shouldn't be merged until at least the testnet is upgraded.

This closes the required items in #668.

@Shaptic Shaptic added the documentation Improvements or additions to documentation label Apr 27, 2022
@Shaptic Shaptic self-assigned this Apr 27, 2022
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

leighmcculloch
leighmcculloch reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions and requests inline.

@Shaptic @leighmcculloch
Specify correct verbiage for seqnum changes
594822f 
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

@Shaptic @leighmcculloch
Consolidate terminology for consistency.
0f0392f 
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

Shaptic and others added 2 commits April 27, 2022 15:46
@Shaptic @leighmcculloch
Reword paragraph relating seqage to timebounds
89364a7 
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@Shaptic
Improve verbiage around account sequence number "touch time".
c987dc4
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

Shaptic and others added 2 commits April 27, 2022 16:34
@Shaptic @leighmcculloch
Improve verbiage around signed payload signers.
6bf67fc 
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@Shaptic
More verbiage and seqnum age improvements
74e37f5
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

rice2000
rice2000 approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@rice2000 rice2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with one existing suggestion, but other than that, these changes are great. Clear, concise, and clean!

@Shaptic @leighmcculloch
Clarify condition type in paragraph body
fe0358c 
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
@Shaptic
Copy link
Contributor Author

Shaptic commented May 6, 2022

This is to be merged after testnet goes live, right? @rice2000

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr673.previews.kube001.services.stellar-ops.com/

@rice2000
Copy link
Contributor

rice2000 commented May 6, 2022

This is to be merged after testnet goes live, right? @rice2000

Yeah: let's merge it Monday.

@rice2000 rice2000 merged commit 3f3f19f into stellar:master May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leighmcculloch leighmcculloch leighmcculloch left review comments

@ire-and-curses ire-and-curses ire-and-curses left review comments

@sisuresh sisuresh sisuresh left review comments

@rice2000 rice2000 rice2000 approved these changes

Assignees

@Shaptic Shaptic

Labels
documentation Improvements or additions to documentation
Projects
No open projects
Protocol 19
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Shaptic @stellar-jenkins @rice2000 @leighmcculloch @ire-and-curses @sisuresh