Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Create Ingestion-filtering.mdx #693

Merged
merged 7 commits into from
Aug 5, 2022
Merged

Create Ingestion-filtering.mdx #693

merged 7 commits into from
Aug 5, 2022

Conversation

jcx120
Copy link
Contributor

@jcx120 jcx120 commented Jul 15, 2022

Ingestion Filtering public doc draft

Ingestion Filtering public doc draft
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@jcx120
Copy link
Contributor Author

jcx120 commented Jul 15, 2022

hi @Shaptic
new doc draft page for ingestion filtering.

Copy link
Contributor Author

@jcx120 jcx120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Looks good

Updating spacing around <CodeExample>
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

<CodeExample>

```
EXP-ENABLE-INGESTION-FILTERING=True.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need underscores not hyphens

Suggested change
EXP-ENABLE-INGESTION-FILTERING=True.
EXP_ENABLE_INGESTION_FILTERING=True

<CodeExample>

```
admin-port=<your_choice>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
admin-port=<your_choice>
--admin-port=[your choice]

attempting to debug build failure
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

Co-authored-by: George <Shaptic@users.noreply.github.com>
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

removed space prefix
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

Removed <CodeExample> tags, which seem unnecessary
@stellar-jenkins
Copy link

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice, ship it

@jcx120
Copy link
Contributor Author

jcx120 commented Aug 5, 2022

@rice2000 Kindly merge this new page for Horizon

@rice2000 rice2000 merged commit cb197a6 into stellar:master Aug 5, 2022
kalepail added a commit that referenced this pull request Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants