Skip to content

FMC coverage & derive #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

FMC coverage & derive #1200

merged 2 commits into from
Apr 25, 2025

Conversation

burrbull
Copy link
Member

No description provided.

Copy link

github-actions bot commented Apr 24, 2025

Memory map comparison

@burrbull burrbull marked this pull request as ready for review April 24, 2025 18:08
@burrbull
Copy link
Member Author

cc @usbalbin

@@ -32,6 +35,7 @@ BCR?:
FACCEN:
Disabled: [0, Corresponding NOR Flash memory access is disabled]
Enabled: [1, Corresponding NOR Flash memory access is enabled]
# TODO: fix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the todo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also can be Bits32 in MWID.
Need to investigate more. In another PR maybe.

Copy link
Member

@usbalbin usbalbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really familiar with the FMC, but LGTM as far as I can tell

@burrbull burrbull added this pull request to the merge queue Apr 25, 2025
Merged via the queue into master with commit b747411 Apr 25, 2025
23 checks passed
@burrbull burrbull deleted the fmc-derive branch April 25, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants