Skip to content

RCC H7 - Fix usb1otg related problem for high mem devices #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

usbalbin
Copy link
Member

@usbalbin usbalbin commented May 5, 2025

No description provided.

@usbalbin usbalbin added the skip-changelog No changelog entry required label May 5, 2025
@usbalbin usbalbin force-pushed the h7-hi-mem-usbotg branch from 8e1f7c1 to 9a94283 Compare May 5, 2025 22:01
@usbalbin
Copy link
Member Author

usbalbin commented May 5, 2025

There seems to be several more things that differs for the H7A3, HB0, HB3 devices

cargo c --features stm32h7b3,rt,defmt,log,xspi,sdmmc,sdmmc-fatfs,fmc,usb_hs,rtc,ethernet,ltdc,crc,rand,can,dsi
   Compiling stm32h7 v0.16.0 (/home/albin/my_projects/stm32-rs/stm32h7)
    Checking stm32h7xx-hal v0.16.0 (/home/albin/my_projects/stm32h7xx-hal)
error[E0599]: no method named `operr` found for struct `R` in the current scope
  --> src/flash/operations.rs:64:22
   |
64 |         } else if sr.operr().bit() {
   |                      ^^^^^ method not found in `R<SRrs>`

error[E0599]: the method `modify` exists for reference `&Reg<SRrs>`, but its trait bounds were not satisfied
   --> src/flash/operations.rs:78:15
    |
78  |     regs.sr().modify(|_, w| {
    |     ----------^^^^^^ method cannot be called on `&Reg<SRrs>` due to unsatisfied trait bounds
    |
   ::: /home/albin/my_projects/stm32-rs/stm32h7/src/stm32h7b3/flash/bank/sr.rs:134:1
    |
134 | pub struct SRrs;
    | --------------- doesn't satisfy `_: Writable`
    |
    = note: the following trait bounds were not satisfied:
            `stm32h7::stm32h7b3::flash::bank::sr::SRrs: Writable`

error[E0599]: no method named `snb` found for mutable reference `&mut W<stm32h7::stm32h7b3::flash::bank::cr::CRrs>` in the current scope
   --> src/flash/operations.rs:174:18
    |
170 | /             w
171 | |                 // start
172 | |                 .start().set_bit()
173 | |                 // sector number
174 | |                 .snb().bits(sector)
    | |                 -^^^ method not found in `&mut W<CRrs>`
    | |_________________|
    |

error[E0599]: no method named `psize` found for mutable reference `&mut W<stm32h7::stm32h7b3::flash::bank::cr::CRrs>` in the current scope
   --> src/flash/operations.rs:219:22
    |
217 | /                 w
218 | |                     // double-word parallelism
219 | |                     .psize().bits(0b11)
    | |                     -^^^^^ method not found in `&mut W<CRrs>`
    | |_____________________|
    |

error[E0599]: no method named `isr` found for struct `Periph<stm32h7::stm32h7b3::rtc::RegisterBlock, 1476411392>` in the current scope
   --> src/rtc.rs:200:13
    |
200 |         rtc.isr().modify(|_, w| w.init().set_bit());
    |             ^^^
    |
help: there is a method `icsr` with a similar name
    |
200 -         rtc.isr().modify(|_, w| w.init().set_bit());
200 +         rtc.icsr().modify(|_, w| w.init().set_bit());
[...]

@usbalbin usbalbin marked this pull request as ready for review May 5, 2025 22:12
@burrbull burrbull added this pull request to the merge queue May 6, 2025
Merged via the queue into stm32-rs:master with commit f11dc3d May 6, 2025
24 checks passed
Copy link

github-actions bot commented May 7, 2025

Memory map comparison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants